Skip to content

refactor: Fixed the PHPCS issues in the deprecated.php file#7659

Open
SH4LIN wants to merge 1 commit intoWordPress:trunkfrom
SH4LIN:refactor/phpcs-issues
Open

refactor: Fixed the PHPCS issues in the deprecated.php file#7659
SH4LIN wants to merge 1 commit intoWordPress:trunkfrom
SH4LIN:refactor/phpcs-issues

Conversation

@SH4LIN
Copy link

@SH4LIN SH4LIN commented Oct 28, 2024

Overview

  • This PR will fix the PHPCS WordPress-core standards issues in the deprecated.php file

Trac ticket: https://core.trac.wordpress.org/ticket/62279


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

@github-actions
Copy link

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props sh4lin.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions
Copy link

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • The Plugin and Theme Directories cannot be accessed within Playground.
  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

Copy link

@apermo apermo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Double checked it, all just cosmetical code style changes, not accidental logic changes found.

Looks good to me.

* @return array Post data.
*/
function get_postdata($postid) {
function get_postdata( $postid ) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why the PHPCS workflow not detected it? I don't think we needs to fix as it was already deprecated 🤔

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As the PR is about applying WPCS to the file, I think this fix should also be included.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants