-
-
Notifications
You must be signed in to change notification settings - Fork 1k
Open
Description
_DidFinishPicking was not set to nil after the call was completed, resulting in a memory leak due to strong references.
YPImagePicker -
start - line 37
before - private func didSelect(items: [YPMediaItem]) {
_didFinishPicking?(items, false)
}
after private func didSelect(items: [YPMediaItem]) {
_didFinishPicking?(items, false)
_didFinishPicking = nil
}
start - line 67
before -
picker.didClose = { [weak self] in
self?._didFinishPicking?([], true)
}
after -
picker.didClose = { [weak self] in
self?._didFinishPicking?([], true)
self?._didFinishPicking = nil
}
Just to be sure
start - line 154
before -
deinit {
print("Picker deinited 👍")
}
after -
deinit {
_didFinishPicking = nil
print("Picker deinited 👍")
}
Metadata
Metadata
Assignees
Labels
No labels