Merged
Conversation
DhairyaSethi
reviewed
Oct 6, 2025
Comment on lines
+333
to
+339
| /// @return The current drawn index of the asset. | ||
| function getAssetDrawnIndex(uint256 assetId) external view returns (uint256); | ||
|
|
||
| /// @notice Returns the current drawn rate for the specified asset. | ||
| /// @param assetId The identifier of the asset. | ||
| /// @return The current drawn rate of the asset. | ||
| function getAssetDrawnRate(uint256 assetId) external view returns (uint256); |
Member
There was a problem hiding this comment.
these don't return the 'current' but rather last stored index and rate. let's correct the natspec or impl (since last stored values are given by getAsset())
DhairyaSethi
approved these changes
Oct 6, 2025
miguelmtzinf
added a commit
that referenced
this pull request
Oct 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes:
_isPositionManagerinternal function modifier changed fromprivatetointernal.IHub, because they were part ofIHubBasealready (dup).