Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds a GitHub Actions workflow to validate that the upload-artifact action respects http_proxy and https_proxy environment variables by forcing all HTTP(S) traffic through a Squid proxy.
Changes:
- Introduces
.github/workflows/test-proxy.ymlwhich runs a containerized Ubuntu job with a Squid proxy service. - Sets up
iptablesrules to block direct outbound HTTP/HTTPS (ports 80/443) while allowing traffic only to the proxy and DNS. - Verifies that direct HTTPS requests fail, HTTPS via the proxy succeeds, and then uploads a test artifact through the proxy using the local action (
uses: ./).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
philip-gai
approved these changes
Jan 30, 2026
boxofyellow
approved these changes
Jan 30, 2026
GhadimiR
approved these changes
Jan 30, 2026
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
fdio-github
pushed a commit
to FDio/csit
that referenced
this pull request
Mar 2, 2026
Bumps actions/upload-artifact from 6 to 7. ## Release notes Sourced from actions/upload-artifact's releases. v7.0.0 v7 What's new Direct Uploads Adds support for uploading single files directly (unzipped). Callers can set the new archive parameter to false to skip zipping the file during upload. Right now, we only support single files. The action will fail if the glob passed resolves to multiple files. The name parameter is also ignored with this setting. Instead, the name of the artifact will be the name of the uploaded file. ESM To support new versions of the @actions/* packages, we've upgraded the package to ESM. What's Changed Add proxy integration test by @Link- in actions/upload-artifact#754 Upgrade the module to ESM and bump dependencies by @danwkennedy in actions/upload-artifact#762 Support direct file uploads by @danwkennedy in actions/upload-artifact#764 New Contributors @Link- made their first contribution in actions/upload-artifact#754 Full Changelog: actions/upload-artifact@v6...v7.0.0 ## Commits bbbca2d Support direct file uploads (#764) 589182c Upgrade the module to ESM and bump dependencies (#762) 47309c9 Merge pull request #754 from actions/Link-/add-proxy-integration-tests 02a8460 Add proxy integration test See full diff in compare view  Signed-off-by: dependabot[bot] <support@github.com> Change-Id: Ia2e29e951761b7cd74c86c9469ca502af2b566f6 GitHub-PR: #4131 GitHub-Hash: ec81e01b2a1da5f9 Signed-off-by: fdio.github <releng+fdio-github@linuxfoundation.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proxy Integration Test for upload-artifact
This test validates that the
upload-artifactaction properly honorshttp_proxyandhttps_proxyenvironment variables.How it works
iptablesto block all direct HTTP/HTTPS traffic (ports 80/443), allowing only traffic through the proxyKey point
If the action ignores the proxy configuration and attempts direct connections, the upload will fail due to iptables blocking. Success indicates the action correctly routes traffic through the configured proxy.