Skip to content

Conversation

@zincnode
Copy link
Contributor

Add social icon for Unsplash.

Unsplash is a website dedicated to sharing stock photography under the Unsplash license.

@adityatelange
Copy link
Owner

@Explore-Space I see unsplash brand icon is diff than what it is in this PR

image

https://unsplash.com/press

@zincnode
Copy link
Contributor Author

@Explore-Space I see unsplash brand icon is diff than what it is in this PR

image

https://unsplash.com/press

Hi,
I also noticed this problem. But I think the camera icon is more in line with the style of other social icons. If the official logo is used, it looks a little inappropriate.

  • Code using official icons
{{- else if (eq $icon_name "unsplash") -}}
<svg viewBox="0 0 32 32" width="32" height="32" xmlns="http://www.w3.org/2000/svg">
    <path d="M10 9V0h12v9H10zm12 5h10v18H0V14h10v9h12v-9z" fill="currentColor" fill-rule="nonzero" />
</svg>
  • The effect of using the above code
    light_mode
    dark_mode

Which style do you think is more appropriate?😂

@adityatelange
Copy link
Owner

@Explore-Space I see unsplash brand icon is diff than what it is in this PR
image
https://unsplash.com/press

Hi,
I also noticed this problem. But I think the camera icon is more in line with the style of other social icons. If the official logo is used, it looks a little inappropriate.

  • Code using official icons
{{- else if (eq $icon_name "unsplash") -}}
<svg viewBox="0 0 32 32" width="32" height="32" xmlns="http://www.w3.org/2000/svg">
    <path d="M10 9V0h12v9H10zm12 5h10v18H0V14h10v9h12v-9z" fill="currentColor" fill-rule="nonzero" />
</svg>
  • The effect of using the above code
    light_mode
    dark_mode

Which style do you think is more appropriate?

I don't mind if you don't have any problem.

@adityatelange
Copy link
Owner

@Explore-Space I was positive with the camera logo ! Didn't get why did you changed it ?

@zincnode
Copy link
Contributor Author

@ Explore-Space我对相机徽标很满意!没明白为什么要更改它吗?

Oh, I'm very sorry, I just lost my mind. Wait a moment, I change it back.

@adityatelange
Copy link
Owner

@ Explore-Space我对相机徽标很满意!没明白为什么要更改它吗?

Oh, I'm very sorry, I just lost my mind. Wait a moment, I change it back.

If you could enabled maintainer edits it I'd do that for you

@zincnode
Copy link
Contributor Author

@探索空间我对相机徽标很满意!没明白为什么要更改它吗?

哦,我很抱歉,我只是失去了我的���海里。请稍等,我将其改回。

如果您可以启用维护者编辑功能,我会为您完成

Okay, then you can help me change it back. Sorry for the trouble.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@adityatelange adityatelange merged commit 45c4b48 into adityatelange:master Feb 20, 2021
@adityatelange adityatelange added the icons Related to Icons label Jun 11, 2021
kylethedeveloper pushed a commit to kylethedeveloper/hugo-PaperMod that referenced this pull request Feb 21, 2023
Co-authored-by: Aditya Telange <21258296+adityatelange@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

icons Related to Icons

2 participants