Added SuccessHttpResponseCode hook setting #266
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revamp of PR #259
Issue 1, 2 and 3 should have been taken care of.
I'm struggling with item 4 though. First time writing go, and I'm a bit lost. I suspect I should modify
webhook_test.goand do something very similar to@adnanh would you mind filling in the blanks here? (I'd be happy to read your patch and learn how to do it myslef for the next patch!) Or alternatively, explaining the details, including how to run tests locally, and I should be able to wrap it up.