Skip to content

Conversation

@aioobe
Copy link
Contributor

@aioobe aioobe commented Sep 15, 2018

Revamp of PR #259

Issue 1, 2 and 3 should have been taken care of.

I'm struggling with item 4 though. First time writing go, and I'm a bit lost. I suspect I should modify webhook_test.go and do something very similar to

// test with custom return code
{"empty payload", "github", nil, `{}`, false, http.StatusBadRequest, `Hook rules were not satisfied.`, ``},
// test with custom invalid http code, should default to 200 OK
{"empty payload", "bitbucket", nil, `{}`, false, http.StatusOK, `Hook rules were not satisfied.`, ``},

@adnanh would you mind filling in the blanks here? (I'd be happy to read your patch and learn how to do it myslef for the next patch!) Or alternatively, explaining the details, including how to run tests locally, and I should be able to wrap it up.

@aioobe
Copy link
Contributor Author

aioobe commented Mar 6, 2019

Any chance we could get closure on this? I'm recommend using this tool in https://github.com/aioobe/dead-simple-jekyll-comments but it's annoying to instruct people to patch it / use a fork.

@adnanh
Copy link
Owner

adnanh commented Mar 11, 2019

Hey, sorry for the wait, I'll get this in as soon as I can. Life is busy at the moment, but hopefully I'll find a few hours this week to get this done.

@adnanh adnanh merged commit 90f751a into adnanh:development Apr 17, 2019
@adnanh
Copy link
Owner

adnanh commented Apr 17, 2019

Thank you very much :-)

@aioobe
Copy link
Contributor Author

aioobe commented Apr 17, 2019

And thank you for creating this awesome little tool. It's used on a daily basis for processing comments over at programming.guide.

@adnanh
Copy link
Owner

adnanh commented Apr 17, 2019

Cool :-) I created it to scratch my own itch, but it's evolved quite a bit since then thanks to this wonderful community.

moorereason added a commit to moorereason/webhook that referenced this pull request Sep 18, 2019
PR adnanh#266 appears to have changed the default response code to StatusOK.
waitForServerReady() was expected a StatusNotFound response, which was
preventing all TestWebhook tests from running.
@moorereason moorereason added this to the 2.6.10 milestone Dec 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants