-
-
Notifications
You must be signed in to change notification settings - Fork 172
Feature: Option to view profile pictures in comments #1125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
This is exactly what I'd envisioned when I wrote my feature request! Thank you @0xCmdrKeen! |
|
Please confirm this issue is ok to work on in the issue before opening a pr (contributing.md). Thank you. |
|
@aeharding it wasn't assigned so I thought it was okay to work on. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Branch needs a rebase. Other than that, are there any plans to take this, @aeharding ?
12e8b8c to
4efb2fc
Compare
|
I see you've raised some concerns as to why this hasn't been merged yet
While i understand the desire to have a fully fleshed out solution would it be possible to incrementally implement it by starting with having this in comments and then I'm sure others would raise PRs if they want it working on profiles, making animated pfps work etc? Otherwise I can try working on that if it would make it more likely to get merged? |
|
@zara2x feel free to take this over if @aeharding is okay with that. I probably won't be continuing to work on this, and given the age of the PR, I assume it might take quite a bit of work to make it functional again. |
Adds a new option "Show avatars in comments" (default: OFF).
When enabled, user names in the comments will have their profile picture shown next to their names.
This fixes #567.