Skip to content

Conversation

@0xCmdrKeen
Copy link
Contributor

Adds a new option "Show avatars in comments" (default: OFF).

When enabled, user names in the comments will have their profile picture shown next to their names.

screenshot screenshot

This fixes #567.

@entropicdrifter
Copy link

This is exactly what I'd envisioned when I wrote my feature request! Thank you @0xCmdrKeen!

@aeharding
Copy link
Owner

Please confirm this issue is ok to work on in the issue before opening a pr (contributing.md). Thank you.

@0xCmdrKeen
Copy link
Contributor Author

@aeharding it wasn't assigned so I thought it was okay to work on.

@0xCmdrKeen 0xCmdrKeen requested a review from aeharding as a code owner April 29, 2024 04:16
Copy link
Contributor

@sharunkumar sharunkumar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Branch needs a rebase. Other than that, are there any plans to take this, @aeharding ?

@aeharding aeharding force-pushed the main branch 4 times, most recently from 12e8b8c to 4efb2fc Compare March 15, 2025 19:36
@zara2x
Copy link

zara2x commented Jun 27, 2025

I see you've raised some concerns as to why this hasn't been merged yet

As for why it isn’t merged in yet, is because it is a PR for a user submitted issue that hasn’t been fully triaged yet. For example, should avatars also be added to profile, autocomplete, post details, account selector etc, should avatars be animated, or frozen etc

While i understand the desire to have a fully fleshed out solution would it be possible to incrementally implement it by starting with having this in comments and then I'm sure others would raise PRs if they want it working on profiles, making animated pfps work etc?

Otherwise I can try working on that if it would make it more likely to get merged?

@0xCmdrKeen
Copy link
Contributor Author

@zara2x feel free to take this over if @aeharding is okay with that. I probably won't be continuing to work on this, and given the age of the PR, I assume it might take quite a bit of work to make it functional again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

5 participants