Fixes failure to launch "new user" / "popular" screens post onboard #110
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a fix for the following issue: https://meta.getaether.net/t/aether-fails-to-show-new-user-modal-after-saying-yes-to-onboarding-question-create-new-user/350 The problem was that a navigation guard was in place preventing navigation outside onboarding screens until onboarding was set to complete in VueX store. This fix ensures that router.push is called only *after* onboarding is successfully set to complete. There is a slight issue with scroll position in the "create new user" screen, where the screen's title is not visible, but it looks alright and feels quite natural at the default window size so I think it's fine. It might be good to make a mixin for resetting the scroll position and use that here just to be sure.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix for the issue I reported here: https://meta.getaether.net/t/aether-fails-to-show-new-user-modal-after-saying-yes-to-onboarding-question-create-new-user/350
The problem was that a navigation guard was in place preventing navigation outside onboarding screens until onboarding was set to complete in VueX store.
This fix ensures that router.push is called only after onboarding is successfully set to complete.
There is a slight issue with scroll position in the "create new user" screen, where the screen's title is not visible, but it looks alright and feels quite natural at the default window size so I think it's fine.
(It might be good to make a mixin for resetting the scroll position and use that just to be sure. I can do that if you like, but I thought you might want to give me guidance on the best way to do it, if in fact it's important.)