Allow support for extra inspectables#206
Merged
Conversation
af
reviewed
Apr 4, 2023
Owner
af
left a comment
af
left a comment
There was a problem hiding this comment.
Thanks for this, I had forgotten all about this suggestion! The implementation looks good, could you just add some tests for the new behavior?
Contributor
Author
Added tests :) |
Owner
|
Thanks! |
Owner
|
Published |
tuannm151
pushed a commit
to BSSCommerce/shopify-envalid
that referenced
this pull request
Jul 1, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was looking for a less boilerplate way to do what is described in #142. I feel like the extra inspectable array option is the way to go.
This will also make removing the custom middleware defined in
nestjs-envalidpossible.