Skip to content

Unknown property idPrefix for component tracked-controls #5772

@vincentfretin

Description

@vincentfretin

Running the tests, I got the message
Unknown property idPrefix for component tracked-controls
logitech-mx-ink-controls and meta-oculus-controls are using id correctly and it's used as idPrefix in checkControllerPresentAndSetup, but all the other controls use idPrefix when setting the tracked-controls component, not sure when this is has been modified, I didn't found the commit where it changed. I'm guessing we just need to change idPrefix by id for all the other components listed here:

$ ag idPrefix src/
src/utils/tracked-controls.js
10: * @param {object} idPrefix - Prefix to match in gamepad id if any.
13:export function checkControllerPresentAndSetup (component, idPrefix, queryObject) {
19:  controller = isControllerPresent(component, idPrefix, queryObject);
57:export function findMatchingControllerWebXR (controllers, idPrefix, handedness, index, iterateProfiles, handTracking) {
72:          controllerMatch = profiles[j].startsWith(idPrefix);
76:        controllerMatch = profiles.length > 0 && profiles[0].startsWith(idPrefix);

src/components/hp-mixed-reality-controls.js
120:      idPrefix: GAMEPAD_ID,

src/components/generic-tracked-controller-controls.js
130:      idPrefix: GAMEPAD_ID_PREFIX,

src/components/vive-focus-controls.js
102:      idPrefix: GAMEPAD_ID_PREFIX

src/components/valve-index-controls.js
121:      idPrefix: GAMEPAD_ID_PREFIX,

src/components/pico-controls.js
113:      idPrefix: GAMEPAD_ID,

src/components/oculus-go-controls.js
106:      idPrefix: GAMEPAD_ID_PREFIX

src/components/windows-motion-controls.js
176:      idPrefix: GAMEPAD_ID_PREFIX,

src/components/vive-controls.js
124:      idPrefix: GAMEPAD_ID_PREFIX,

src/components/magicleap-controls.js
115:      idPrefix: GAMEPAD_ID_COMPOSITE,

src/components/tracked-controls.js
72:   * Handle update controller match criteria (such as `id`, `idPrefix`, `hand`, `controller`)

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions