Distortion map texture properties #4932
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…match the main source texture
dmarcos
reviewed
Sep 21, 2021
src/utils/material.js
Outdated
| rendererSystem.applyColorCorrection(texture); | ||
| } | ||
| if (texture) { | ||
| module.exports.setTextureProperties(texture, data); |
Member
There was a problem hiding this comment.
I think we can name the function above:
module.exports.setTextureProperties = function setTextureProperties(texture, data) {
and call it here:
if (texture) { setTextureProperties(texture, data); }
A bit cleaner
Member
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Distortion maps were using the default Wrapping so that when a normal map and a map were provided and there was repeating
the texture would end up cut off e.g.:
Changes proposed: