Bug fixes for WebXR layers: #4991
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Request "local-floor" reference space to match three.js default. Init loading screen images for quad layer Check mono layout instead of monocubemap to ensure we ask for the proper subimage type.
Member
|
Thanks so much! I just made a comment to clarify |
dmarcos
reviewed
Jan 14, 2022
snagy
commented
Jan 20, 2022
Contributor
Author
snagy
left a comment
snagy
left a comment
There was a problem hiding this comment.
Tested on my Quest 2, looks good.
Member
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Request "local-floor" reference space to match three.js default.
Init loading screen images for quad layer
Check mono layout instead of monocubemap to ensure we ask for the proper subimage type.