Skip to content

Conversation

@arpu
Copy link
Contributor

@arpu arpu commented Apr 5, 2024

using upstream debug ^4.3.4

tested with http://localhost:8080/showcase/spatial-ui/

core:component:warn Unknown property `radius` for component `geometry`. +0ms
core:component:warn Unknown property `color` for component `material`. +0ms

old debug:

core:component:warn Unknown property `radius` for component `geometry`. 
core:component:warn Unknown property `color` for component `material`. 
@dmarcos
Copy link
Member

dmarcos commented Apr 5, 2024

Yeah debug for was to remove the timestamps. Can we get rid of them? Thanks

@arpu
Copy link
Contributor Author

arpu commented Apr 5, 2024

Yes, overwrite the debug.formatArgs, and add the colors and remove the Time works, Idea from debug-js/debug#582 (comment)

Original Code uses const/let https://github.com/debug-js/debug/blob/f66cb2d9f729e1a592e72d3698e3b75329d75a25/src/browser.js#L146

@dmarcos should this be changed to vars?

@dmarcos
Copy link
Member

dmarcos commented Apr 6, 2024

Yes we don't use let / var. Code style has to be consistent with rest of code base.

@arpu arpu requested a review from dmarcos April 8, 2024 12:13
@dmarcos
Copy link
Member

dmarcos commented Apr 9, 2024

Thanks so much!

@dmarcos dmarcos merged commit e65ea4e into aframevr:master Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants