Skip to content

Add webpack config to create a module bundle to be used with importmap #5640

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dmarcos merged 3 commits into from
Jan 23, 2025
Merged

Add webpack config to create a module bundle to be used with importmap #5640

dmarcos merged 3 commits into from
Jan 23, 2025

Conversation

@vincentfretin
Copy link
Contributor

@vincentfretin vincentfretin commented Jan 23, 2025

Description:

Add webpack config to create a module bundle to be used with importmap

Changes proposed:

  • Move shared config in webpack.common.js
  • Create new webpack.module.config.js and npm run dist:module command

After merge, please commit the new bundle:

npm run dist
git add dist/aframe-master.module.min.js dist/aframe-master.module.min.js.map
git commit -m"Add new module bundle"
@vincentfretin vincentfretin mentioned this pull request Jan 23, 2025
Merged
@dmarcos
Copy link
Member

dmarcos commented Jan 23, 2025

Thanks!
@dmarcos dmarcos merged commit 3ce9c22 into aframevr:master Jan 23, 2025
3 checks passed
@vincentfretin vincentfretin deleted the module-build branch January 24, 2025 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@vincentfretin @dmarcos