Skip to content

Add package-lock.json and enable npm cache in CI #5693

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dmarcos merged 2 commits into from
Mar 12, 2025
Merged

Add package-lock.json and enable npm cache in CI #5693

dmarcos merged 2 commits into from
Mar 12, 2025
+15,368 −5

Conversation

@vincentfretin
Copy link
Contributor

@vincentfretin vincentfretin commented Mar 12, 2025

Description:

For reproducible builds, add package-lock.json to the repo.

Changes proposed:

  • Remove package-lock.json from .gitignore
  • Add package-lock.json to repo
  • Enable npm cache in CI
@vincentfretin vincentfretin mentioned this pull request Mar 12, 2025
Merged
@vincentfretin
Copy link
Contributor Author

vincentfretin commented Mar 12, 2025

You need to update the bot as well to not remove package-lock.json, see supermedium/a-frobot#6
@vincentfretin vincentfretin mentioned this pull request Mar 12, 2025
Closed
@dmarcos dmarcos merged commit 43585cc into aframevr:master Mar 12, 2025
3 checks passed
@vincentfretin vincentfretin deleted the commit-package-lock branch March 13, 2025 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@vincentfretin @dmarcos