Remove bad code in meta-touch-controls for thumbstick rotation #5775
+0
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ives error with Rift controllers
vincentfretin
force-pushed
the
dead-code-meta-touch-controls
branch
from
5b6e267 to
e087f44
Compare
Member
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Remove bad code in meta-touch-controls for thumbstick rotation that gives error with Rift controllers.
That was reported on discord for aframe 1.7.1
https://discord.com/channels/479784974917042186/479787777949433900/1428015046046257213
For context, that code with originalRotation was originally written in efb5c3a to support button highlighting for Oculus 2 controllers, that part of the code wasn't properly checking for isOculusTouchV3. And that code was later modified in 97b8a2b to support Meta Quest Pro, removing this originalRotation, adding a specific code path for isTouchV3orPROorPlus so making that block of code really dead.