Feature/command timeout and execd headers#227
Merged
ninan-nn merged 2 commits intoalibaba:mainfrom Feb 11, 2026
Merged
Conversation
Pangjiping
reviewed
Feb 11, 2026
...n/kotlin/com/alibaba/opensandbox/sandbox/domain/models/execd/executions/RunCommandRequest.kt
Outdated
Show resolved
Hide resolved
sdks/sandbox/python/src/opensandbox/adapters/converter/execution_converter.py
Outdated
Show resolved
Hide resolved
ninan-nn
force-pushed
the
feature/command_timeout_and_execd_headers
branch
from
e3b3ed4 to
794f2e3
Compare
hittyt
reviewed
Feb 11, 2026
...in/kotlin/com/alibaba/opensandbox/sandbox/infrastructure/adapters/service/CommandsAdapter.kt
Outdated
Show resolved
Hide resolved
.../kotlin/com/alibaba/opensandbox/sandbox/infrastructure/adapters/service/FilesystemAdapter.kt
Outdated
Show resolved
Hide resolved
Collaborator
|
@codex review |
![chatgpt-codex-connector[bot]](https://cdn.statically.io/img/avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 794f2e3bdf
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
...in/kotlin/com/alibaba/opensandbox/sandbox/infrastructure/adapters/service/CommandsAdapter.kt
Show resolved
Hide resolved
.../kotlin/com/alibaba/opensandbox/sandbox/infrastructure/adapters/service/FilesystemAdapter.kt
Show resolved
Hide resolved
ninan-nn
force-pushed
the
feature/command_timeout_and_execd_headers
branch
from
794f2e3 to
6ac056b
Compare
ninan-nn
force-pushed
the
feature/command_timeout_and_execd_headers
branch
from
6ac056b to
800129d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
Breaking Changes
Checklist