Skip to content

Fix subtractive overflow #314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
cancanyang wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix subtractive overflow #314

cancanyang wants to merge 1 commit into from

Conversation

@cancanyang
Copy link

@cancanyang cancanyang commented Apr 15, 2022

There is a possibility that currentTimestamp is smaller than oldestTimestamp, creating an overflow and causing normal data to be cleaned up
janisz
janisz reviewed Apr 21, 2022
View reviewed changes
shard.go
keyHash := readHashFromEntry(oldestEntry)
if keyHash == 0 || (currentTimestamp >= oldestTimestamp &&
currentTimestamp-oldestTimestamp > s.lifeWindow) {

Copy link
Collaborator

@janisz janisz Apr 21, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a test for it?
@janisz janisz requested a review from cristaloleg April 21, 2022 11:40
@janisz
Copy link
Collaborator

janisz commented Nov 4, 2022

@cancanyang ping
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@cancanyang @janisz