Skip to content

Rebase#3600

Open
avhirupc wants to merge 59 commits intoalshedivat:masterfrom
avhirupc:master
Open

Rebase#3600
avhirupc wants to merge 59 commits intoalshedivat:masterfrom
avhirupc:master

Conversation

@avhirupc
Copy link
Copy Markdown

Rebase

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 829d3ab283

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread _pages/resume.md Outdated
title: resume
description: resume
published: true
redirect: {{ site.url }}/assets/pdf/Avhirup_Search_Resume.pdf
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Quote Liquid redirect value in resume front matter

The redirect entry is written as {{ site.url }}/assets/pdf/Avhirup_Search_Resume.pdf without quotes, which is invalid YAML because {} is parsed as a flow mapping. When Jekyll parses front matter for _pages, this can raise a YAML syntax error and stop the site build instead of publishing. Quote this value (or use a plain literal URL) so the page metadata parses correctly.

Useful? React with 👍 / 👎.

</div>
title: Ask
description:
img: Ask, a QnA platform (similar to Quora)
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Put Ask summary in description instead of img

This assigns prose text to img, but the projects template treats any non-empty img as an image URL and renders it directly in <img src=...>. As a result, the project tile generates a malformed URL and shows a broken thumbnail on /projects/; the blurb should be in description and img should be empty or a valid image path.

Useful? React with 👍 / 👎.

@maxstridde
Copy link
Copy Markdown

seems like a personal project, accidentally pushed to this repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants