[Jetchat] Update to Material 3#690
Merged
ricknout merged 9 commits intoandroid:mainfrom Oct 27, 2021
ricknout:jetchat-material3
Merged
[Jetchat] Update to Material 3#690ricknout merged 9 commits intoandroid:mainfrom ricknout:jetchat-material3
ricknout merged 9 commits intoandroid:mainfrom
ricknout:jetchat-material3
Conversation
Jetchat/app/src/main/java/com/example/compose/jetchat/components/JetchatIcon.kt
Show resolved
Hide resolved
Jetchat/app/src/main/java/com/example/compose/jetchat/conversation/UserInput.kt
Outdated
Show resolved
Hide resolved
nickbutcher
reviewed
Oct 26, 2021
Jetchat/app/src/main/java/com/example/compose/jetchat/components/JetchatAppBar.kt
Outdated
Show resolved
Hide resolved
nickbutcher
reviewed
Oct 26, 2021
Jetchat/app/src/main/java/com/example/compose/jetchat/components/JetchatDrawer.kt
Outdated
Show resolved
Hide resolved
nickbutcher
reviewed
Oct 26, 2021
Jetchat/app/src/main/java/com/example/compose/jetchat/components/JetchatDrawer.kt
Outdated
Show resolved
Hide resolved
nickbutcher
reviewed
Oct 26, 2021
Jetchat/app/src/main/java/com/example/compose/jetchat/conversation/UserInput.kt
Show resolved
Hide resolved
nickbutcher
reviewed
Oct 26, 2021
Jetchat/app/src/main/java/com/example/compose/jetchat/profile/Profile.kt
Show resolved
Hide resolved
nickbutcher
reviewed
Oct 26, 2021
Jetchat/app/src/main/java/com/example/compose/jetchat/theme/Themes.kt
Outdated
Show resolved
Hide resolved
nickbutcher
reviewed
Oct 26, 2021
nickbutcher
reviewed
Oct 26, 2021
nickbutcher
reviewed
Oct 26, 2021
Contributor
nickbutcher
left a comment
nickbutcher
left a comment
There was a problem hiding this comment.
Was it intentional to update other samples to compose 1.1.0 snapshots and respective Accompanist version?
Contributor
Author
|
@nickbutcher this branch was branched from #684, and the dependencies (for Jetchat at least) are required here |
Collaborator
|
There's a bug with overscroll when you open the app and try to scroll. Tried on Android 12 emulator. This bug isn't present in the main branch. |
Contributor
Author
|
@JolandaVerhoef hmm this could perhaps be a bug in Compose Foundation 1.1.0-beta01, which is where the new stretch overscroll is happening. Any chance you can try and replicate on this branch: #684 ? |
Collaborator
|
Yes, that branch has the same issue. |
Collaborator
|
Ok this was due to my emulator. |
JolandaVerhoef
approved these changes
Oct 27, 2021
nickbutcher
approved these changes
Oct 27, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
androidx.compose.material3