[Crane] Use AnimatedContent to transition between content states.#843
Merged
[Crane] Use AnimatedContent to transition between content states.#843
Conversation
Collaborator
riggaroo
commented
Jun 13, 2022
riggaroo
commented
| Before | After |
|---|---|
| https://user-images.githubusercontent.com/9973046/173384749-7729f3e0-08ad-427f-b0a1-fbebc01309a0.mp4 | https://user-images.githubusercontent.com/9973046/173383605-d17c5339-0453-49b6-b066-ff5bbad91bfe.mp4 |
Crane/app/src/main/java/androidx/compose/samples/crane/home/CraneHome.kt
Outdated
Show resolved
Hide resolved
Crane/app/src/main/java/androidx/compose/samples/crane/home/CraneHome.kt
Outdated
Show resolved
Hide resolved
| slideOutOfContainer( | ||
| towards = direction, | ||
| animationSpec = tween(600) | ||
| ) using SizeTransform(clip = false, sizeAnimationSpec = { initialSize, targetSize -> |
Contributor
There was a problem hiding this comment.
Formatting nit: I'd push SizeTransform into a new line and split out its params into individual rows, just for readability
Collaborator
Author
There was a problem hiding this comment.
When using the notion with it can't be split onto a new line as its actually an argument
simona-anomis
approved these changes
Jun 20, 2022
Contributor
simona-anomis
left a comment
simona-anomis
left a comment
There was a problem hiding this comment.
LGTM with minor nit comments, feel free to not resolve them :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.