fix(tui): rejecting any stacked permission of a subagent terminates it's session - #11944
Closed
IdrisGit wants to merge 2 commits into
Closed
Conversation
…stead of terminating with rejected error if user provides a reason
Contributor
|
The following comment was made by an LLM, it may be inaccurate: No duplicate PRs found |
Contributor
Author
|
hey @rekram1-node @thdxr can I get a review on this PR, this can become base for the "reject with reason" in main agent as well |
Contributor
|
Closing this pull request because it has had no updates for more than 60 days. If you plan to continue working on it, feel free to reopen or open a new PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
fixes #11932 where rejecting one of subagent's stacked permissions cascades and terminates the session instead of continuing with the reason.
This is achieved by providing a proper cascading error message for rest of the permissions instead of
RejectedErrorwhich terminates the session.How did you verify your code works?
screen recording
subagent_reject_multiple_issue_fix_compressed.mp4
screen recording session share link: https://opncd.ai/share/2PdOHkY7