fix(question): implement recovery for pending questions when app starts#15603
Open
aklajnert wants to merge 2 commits intoanomalyco:devfrom
Open
fix(question): implement recovery for pending questions when app starts#15603aklajnert wants to merge 2 commits intoanomalyco:devfrom
aklajnert wants to merge 2 commits intoanomalyco:devfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #15172
Type of change
What does this PR do?
When OpenCode restarts, unanswered question tool calls (persisted as "running" or "aborted" parts in the DB) were lost from the in-memory pending state, making them invisible to the user.
Added a
recover()function inQuestionthat runs once on firstlist()call. It scansPartTablefor question tool parts that are still running or were aborted mid-execution, reconstitutes them as pending question requests, and publishes the appropriate events so both TUI and GUI display them. When the user answers or dismisses a recovered question, the DB part is updated to reflect the outcome. The TUI bootstrap also callsquestion.list()to populate the store with any recovered questions on startup.How did you verify your code works?
Manual testing with running
bun run dev -s <my-sessionid>to check it loads the question correctly.Added a couple of test checking that
recover()function works correctly.Screenshots / recordings
N/A — no UI changes, behavior change only (recovered questions now appear in existing UI)
Checklist