Skip to content

refactor(session): effectify SessionRevert service - #20143

Merged
kitlangton merged 2 commits into
devfrom
worktree-effectify-revert
Mar 31, 2026
Merged

refactor(session): effectify SessionRevert service#20143
kitlangton merged 2 commits into
devfrom
worktree-effectify-revert

Conversation

@kitlangton

Copy link
Copy Markdown
Contributor

Summary

Convert SessionRevert to Effect service pattern.

  • Interface / Service / Layer / makeRuntime with async facades
  • Use Session.Service and Bus.Service directly instead of facades
  • Cross-service calls (SessionPrompt.assertNotBusy, Snapshot., Storage.) remain as facade calls to avoid circular deps

Test plan

  • 195 session/server tests pass, 0 fail
@kitlangton
kitlangton force-pushed the worktree-effectify-revert branch 2 times, most recently from d214045 to a1cd762 Compare March 31, 2026 00:09
@kitlangton
kitlangton marked this pull request as ready for review March 31, 2026 00:10
@kitlangton
kitlangton force-pushed the worktree-effectify-revert branch 4 times, most recently from a22d2df to 07d6267 Compare March 31, 2026 01:17
Convert SessionRevert to Effect service pattern with Interface,
Service, Layer, and async facades. Use Session.Service and Bus.Service
directly instead of facades.
@kitlangton
kitlangton force-pushed the worktree-effectify-revert branch from 888cf56 to c04e0d3 Compare March 31, 2026 01:34
Convert SessionRevert to Effect service pattern. Use Session.Service,
Snapshot.Service, Storage.Service, and Bus.Service directly.
@kitlangton
kitlangton force-pushed the worktree-effectify-revert branch from c04e0d3 to 26f64ad Compare March 31, 2026 01:37
@kitlangton
kitlangton merged commit 3fc0367 into dev Mar 31, 2026
8 checks passed
@kitlangton
kitlangton deleted the worktree-effectify-revert branch March 31, 2026 23:14
jeromelau pushed a commit to jeromelau/opencode that referenced this pull request Apr 2, 2026
vicary pushed a commit to vicary/opencode that referenced this pull request Apr 6, 2026
balcsida pushed a commit to balcsida/opencode that referenced this pull request Apr 8, 2026
xywsxp pushed a commit to xywsxp/opencode that referenced this pull request Apr 24, 2026
Rwanbt pushed a commit to Rwanbt/unifia that referenced this pull request May 5, 2026
AIALRA-0 pushed a commit to AIALRA-0/opencode-turn-engine that referenced this pull request Jun 10, 2026
AIALRA-0 pushed a commit to AIALRA-0/opencode-turn-engine that referenced this pull request Jun 10, 2026
avion23 pushed a commit to avion23/opencode that referenced this pull request Jun 10, 2026
Rwanbt pushed a commit to Rwanbt/unifia that referenced this pull request Jun 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment