Skip to content

refactor: standardize InstanceState variable name to state - #20267

Merged
kitlangton merged 6 commits into
devfrom
worktree-concerns
Apr 1, 2026
Merged

refactor: standardize InstanceState variable name to state#20267
kitlangton merged 6 commits into
devfrom
worktree-concerns

Conversation

@kitlangton

Copy link
Copy Markdown
Contributor

Summary

Rename cachestate for the InstanceState handle across 8 services for naming consistency. All services now use state (the majority convention, 14 services already did).

Files changed: bus, session/prompt, pty, command, tool/registry, plugin, mcp, provider/provider

Test plan

  • 360 pass, 0 fail across session/server/file/skill/mcp tests
Rename cache → state across all services for consistency. The
InstanceState handle is now always named state, matching the
majority convention.
…gistry

The cache→state rename caused inner InstanceState.get() results to
shadow the outer state handle, breaking type inference. Rename inner
bindings to `s` to match the convention used in the other files.
@kitlangton
kitlangton marked this pull request as ready for review April 1, 2026 02:53
@kitlangton
kitlangton merged commit 5fd833a into dev Apr 1, 2026
11 of 12 checks passed
@kitlangton
kitlangton deleted the worktree-concerns branch April 1, 2026 14:39
katosun2 pushed a commit to katosun2/opencode that referenced this pull request Apr 2, 2026
jeromelau pushed a commit to jeromelau/opencode that referenced this pull request Apr 2, 2026
cavaldos pushed a commit to cavaldos/openpentest that referenced this pull request Apr 6, 2026
balcsida pushed a commit to balcsida/opencode that referenced this pull request Apr 8, 2026
xywsxp pushed a commit to xywsxp/opencode that referenced this pull request Apr 24, 2026
Rwanbt pushed a commit to Rwanbt/unifia that referenced this pull request May 5, 2026
AIALRA-0 pushed a commit to AIALRA-0/opencode-turn-engine that referenced this pull request Jun 10, 2026
AIALRA-0 pushed a commit to AIALRA-0/opencode-turn-engine that referenced this pull request Jun 10, 2026
avion23 pushed a commit to avion23/opencode that referenced this pull request Jun 10, 2026
Rwanbt pushed a commit to Rwanbt/unifia that referenced this pull request Jun 14, 2026
AmaanBilwar pushed a commit to AmaanBilwar/opencode that referenced this pull request Aug 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

1 participant