Skip to content

perf(review): defer offscreen diff mounts - #20469

Merged
nexxeln merged 2 commits into
devfrom
nxl/viewport-review-diffs
Apr 1, 2026
Merged

perf(review): defer offscreen diff mounts#20469
nexxeln merged 2 commits into
devfrom
nxl/viewport-review-diffs

Conversation

@nexxeln

@nexxeln nexxeln commented Apr 1, 2026

Copy link
Copy Markdown
Member

summary

  • only mount expanded review diffs when they are in or near the viewport, while keeping focused rows pinned
  • group review comments per file once and render offscreen rows as placeholders to reduce expand-all work

testing

  • bun typecheck
@nexxeln
nexxeln merged commit 44f8301 into dev Apr 1, 2026
9 checks passed
@nexxeln
nexxeln deleted the nxl/viewport-review-diffs branch April 1, 2026 13:59
katosun2 pushed a commit to katosun2/opencode that referenced this pull request Apr 2, 2026
@nexxeln Ryu
perf(review): defer offscreen diff mounts (anomalyco#20469)
ebbc2dc
jeromelau pushed a commit to jeromelau/opencode that referenced this pull request Apr 2, 2026
@nexxeln liuzeming
perf(review): defer offscreen diff mounts (anomalyco#20469)
dc3dd42
balcsida pushed a commit to balcsida/opencode that referenced this pull request Apr 8, 2026
@nexxeln @balcsida
perf(review): defer offscreen diff mounts (anomalyco#20469)
4f04eb0
@achin90 achin90 mentioned this pull request Apr 10, 2026
Closed
xywsxp pushed a commit to xywsxp/opencode that referenced this pull request Apr 24, 2026
@nexxeln
perf(review): defer offscreen diff mounts (anomalyco#20469)
e357091
Rwanbt pushed a commit to Rwanbt/unifia that referenced this pull request May 5, 2026
@nexxeln
perf(review): defer offscreen diff mounts (anomalyco#20469)
4ffcd39
AIALRA-0 pushed a commit to AIALRA-0/opencode-turn-engine that referenced this pull request Jun 10, 2026
@nexxeln
perf(review): defer offscreen diff mounts (anomalyco#20469)
2506c81
AIALRA-0 pushed a commit to AIALRA-0/opencode-turn-engine that referenced this pull request Jun 10, 2026
@nexxeln
perf(review): defer offscreen diff mounts (anomalyco#20469)
505970d
avion23 pushed a commit to avion23/opencode that referenced this pull request Jun 10, 2026
@nexxeln
perf(review): defer offscreen diff mounts (anomalyco#20469)
2034109
Rwanbt pushed a commit to Rwanbt/unifia that referenced this pull request Jun 14, 2026
@nexxeln
perf(review): defer offscreen diff mounts (anomalyco#20469)
7f079c1
MarsQiu007 referenced this pull request in MarsQiu007/openNovel Jul 31, 2026
@nexxeln
perf(review): defer offscreen diff mounts (#20469)
7528e03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

1 participant

@nexxeln