feat: restore auto-accept UI button in prompt input - #23286
Closed
anduimagui wants to merge 2 commits into
Closed
Conversation
- Extract auto-accept button into separate AutoAcceptButton component - Import and use AutoAcceptButton in prompt-input.tsx - Keep existing settings toggle in settings-general.tsx - Update e2e tests to use prompt-permissions button This restores the quick-access auto-accept button in the prompt input while keeping the settings toggle for users who prefer that path.
github-actions
Bot
added
the
needs:compliance
Contributor
|
This PR doesn't fully meet our contributing guidelines and PR template. What needs to be fixed:
Please edit this PR description to address the above within 2 hours, or it will be automatically closed. If you believe this was flagged incorrectly, please let a maintainer know. |
Resolved conflicts: - packages/app/src/components/prompt-input.tsx: Kept both AutoAcceptButton import and upstream's useQuery/bootstrap imports - packages/app/e2e/prompt/prompt-shell.spec.ts: Deleted (removed upstream) - packages/app/e2e/session/session-composer-dock.spec.ts: Deleted (removed upstream)
Contributor
|
This pull request has been automatically closed because it was not updated to meet our contributing guidelines within the 2-hour window. Feel free to open a new pull request that follows our guidelines. |
github-actions
Bot
removed
the
needs:compliance
|
@anduimagui Nice PR, seems it got auto rejected 😭 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR restores the auto-accept permissions button in the prompt input UI while keeping the existing settings toggle.
Changes
AutoAcceptButtoncomponent that encapsulates the auto-accept toggle logicAutoAcceptButtoninprompt-input.tsxsettings-general.tsxunchangedprompt-permissionsbutton instead of settingsRationale
The auto-accept button was removed from the prompt input in #21308 and moved entirely to settings. This PR restores the quick-access button in the prompt input for users who prefer the convenience of toggling auto-accept directly from the composer, while keeping the settings option available for those who prefer that path.
Testing
prompt-shell.spec.tsto use the prompt buttonsession-composer-dock.spec.tsto use the prompt buttonRelated: Reverts the UI removal portion of #21308