feat(docker): improve debian-dev Dockerfile build caching #12807
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
size:M
sihyeonn
force-pushed
the
feat/sh-improve-dockerfile
branch
from
a9c6280 to
7d03549
Compare
Optimize Docker layer caching to significantly reduce rebuild time when only source code changes: - Separate dependency installation from source code copy - Build brotli in build stage instead of runtime stage - Copy only dependency-related files before running make deps Signed-off-by: Sihyeon Jang <sihyeon.jang@navercorp.com>
sihyeonn
force-pushed
the
feat/sh-improve-dockerfile
branch
from
7d03549 to
ed1042a
Compare
Baoyuantop
reviewed
Dec 12, 2025
Contributor
Baoyuantop
left a comment
Baoyuantop
left a comment
There was a problem hiding this comment.
Is there a significant change in the size of the image?
docker/debian-dev/Dockerfile
Outdated
| COPY ${INSTALL_BROTLI} /install-brotli.sh | ||
| RUN chmod +x /install-brotli.sh \ | ||
| && cd / && ./install-brotli.sh && rm -rf /install-brotli.sh | ||
| RUN echo /usr/local/brotli/lib | tee /etc/ld.so.conf.d/brotli.conf \ |
Contributor
There was a problem hiding this comment.
Please note the handling of the lib64 directory in the original install-brotli.sh script. https://github.com/apache/apisix/blob/master/docker/debian-dev/install-brotli.sh#L28-L32
Author
There was a problem hiding this comment.
Thanks for your review! I handled it.
Baoyuantop
added
the
wait for update
Add conditional logic to check for lib64 directory existence, matching the behavior of the original install-brotli.sh script. Signed-off-by: Sihyeon Jang <sihyeon.jang@navercorp.com>
Author
|
@Baoyuantop The main benefit of this PR is improved build caching - brotli is now built once in the build stage and reused across rebuilds, rather than being rebuilt every time in the runtime stage. The image size remains similar because we're copying the same brotli binaries, just from a different stage. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Optimize the debian-dev Dockerfile to leverage Docker layer caching more effectively.
Previously, any code change would invalidate the cache and trigger a full rebuild including
make depsand brotli compilation.What this PR does:
Separate dependency files from source code: Copy only
Makefile,rockspec,.requirements, andinstall-dependencies.shbefore runningmake deps, so dependencies are cached unless these files change.Move brotli build to build stage: Previously, brotli was built in the runtime stage, requiring installation of ~80 build packages (gcc, cmake, etc.) every time. Now it's built once in the build stage and only the binary is copied to runtime.
Performance improvement:
Which issue(s) this PR fixes:
Fixes #
Checklist