-
Notifications
You must be signed in to change notification settings - Fork 1.1k
feat: allow for parallel execution of make eunit sub-targets
#5808
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This is in preparation for using parallel make features. Since both .PHONY couch and src/couch exist, the parallising of src/* would clobber the top level .PHONY couch target.
When called with -jN for N>1, make will run `rebar -r eunit` for
all src/* Erlang apps (without the default skipped ones) up to the
limit of N times in parallel.
This is best used with GNU Make, as it allows for controlling the
output of each subtask to be grouped. BSD Make has no such feature
and interleaves all parallel target’s output, making it hard to
read.
For example:
gmake -j2 --output-sync=target
will run two test suites in parallel and keep their respective
outputs separated. It does this by buffering all output before a
task is done that means for the first few tests, you don’t see
output as you do with serial execution.
On my machine I can run up to -j6 relatively stable, making use
of all 14 cores. Beyond that, Spurious errors can occur. I’ll
file those separately.
-j2 shows an almost 2x speed improvement, as expected and things
scale relatively linarly up until ~2.5 minutes of runtime, which
seems to be a lower bound with all our various setup and wait
bits.
For comparison, -j1, that is serial execution takes about 10.5
minutes on this machine.
Use with care in CI, but definitely use on your local dev machine.
…tion of a shards db
This is achived by configuring each couch_server launched with separate etc, data and log directories. These directories are cleaned up after successful test runs.
big-r81
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
big-r81
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should add the changes to the Makefile.win file too, because if we do the next release, this will fail on Windows ...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
after discussing this with Jan on Slack, the modifications for Windows come with a new PR (in a timely manner)
feat: allow for parallel execution of
make eunitsub-targetsWhen called with -jN for N>1, make will run
rebar -r eunitforall src/* Erlang apps (without the default skipped ones) up to the
limit of N times in parallel.
This is best used with GNU Make, as it allows for controlling the
output of each subtask to be grouped. BSD Make has no such feature
and interleaves all parallel target’s output, making it hard to
read.
For example:
will run two test suites in parallel and keep their respective
outputs separated. It does this by buffering all output before a
task is done that means for the first few tests, you don’t see
output as you do with serial execution.
On my machine I can run up to -j6 relatively stable, making use
of all 14 cores. Beyond that, Spurious errors can occur. I’ll
file those separately.
-j2 shows an almost 2x speed improvement, as expected and things
scale relatively linarly up until ~2.5 minutes of runtime, which
seems to be a lower bound with all our various setup and wait
bits.
For comparison, -j1, that is serial execution takes about 10.5
minutes on this machine.
Use with care in CI, but definitely use on your local dev machine.
Internally, his is achieved by configuring each couch_server launched
with separate etc, data and log directories. These directories
are cleaned up after successful test runs.
In addition,
nouveau/had to be moved toextra/nouveauto avoiddynamic make target clobbering.
This work is in accordance with M1 of the Sovereign Tech Agency
Statement of Work.