Skip to content

Conversation

@janl
Copy link
Member

@janl janl commented Dec 4, 2025

feat: allow for parallel execution of make eunit sub-targets

When called with -jN for N>1, make will run rebar -r eunit for
all src/* Erlang apps (without the default skipped ones) up to the
limit of N times in parallel.

This is best used with GNU Make, as it allows for controlling the
output of each subtask to be grouped. BSD Make has no such feature
and interleaves all parallel target’s output, making it hard to
read.

For example:

gmake -j2 --output-sync=target

will run two test suites in parallel and keep their respective
outputs separated. It does this by buffering all output before a
task is done that means for the first few tests, you don’t see
output as you do with serial execution.

On my machine I can run up to -j6 relatively stable, making use
of all 14 cores. Beyond that, Spurious errors can occur. I’ll
file those separately.

-j2 shows an almost 2x speed improvement, as expected and things
scale relatively linarly up until ~2.5 minutes of runtime, which
seems to be a lower bound with all our various setup and wait
bits.

For comparison, -j1, that is serial execution takes about 10.5
minutes on this machine.

Use with care in CI, but definitely use on your local dev machine.

Internally, his is achieved by configuring each couch_server launched
with separate etc, data and log directories. These directories
are cleaned up after successful test runs.

In addition, nouveau/ had to be moved to extra/nouveau to avoid
dynamic make target clobbering.

This work is in accordance with M1 of the Sovereign Tech Agency
Statement of Work.

janl added 8 commits December 4, 2025 10:40
This is in preparation for using parallel make features.

Since both .PHONY couch and src/couch exist, the parallising
of src/* would clobber the top level .PHONY couch target.
When called with -jN for N>1, make will run `rebar -r eunit` for
all src/* Erlang apps (without the default skipped ones) up to the
limit of N times in parallel.

This is best used with GNU Make, as it allows for controlling the
output of each subtask to be grouped. BSD Make has no such feature
and interleaves all parallel target’s output, making it hard to
read.

For example:

    gmake -j2 --output-sync=target

will run two test suites in parallel and keep their respective
outputs separated. It does this by buffering all output before a
task is done that means for the first few tests, you don’t see
output as you do with serial execution.

On my machine I can run up to -j6 relatively stable, making use
of all 14 cores. Beyond that, Spurious errors can occur. I’ll
file those separately.

-j2 shows an almost 2x speed improvement, as expected and things
scale relatively linarly up until ~2.5 minutes of runtime, which
seems to be a lower bound with all our various setup and wait
bits.

For comparison, -j1, that is serial execution takes about 10.5
minutes on this machine.

Use with care in CI, but definitely use on your local dev machine.
This is achived by configuring each couch_server launched
with separate etc, data and log directories. These directories
are cleaned up after successful test runs.
@janl janl mentioned this pull request Dec 6, 2025
Copy link
Contributor

@big-r81 big-r81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Copy link
Contributor

@big-r81 big-r81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should add the changes to the Makefile.win file too, because if we do the next release, this will fail on Windows ...

Copy link
Contributor

@big-r81 big-r81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

after discussing this with Jan on Slack, the modifications for Windows come with a new PR (in a timely manner)

@janl janl merged commit 88fcdce into main Dec 6, 2025
50 checks passed
@janl janl deleted the jenkins-parallel-eunit branch December 6, 2025 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants