Use usize rather than Option<usize> to represent Limit::skipand Limit::offset - #3374
Merged
Conversation
Signed-off-by: remzi <13716567376yh@gmail.com>
Contributor
Author
|
Mark this as draft as I only update the logical plan so far. |
HaoYang670
marked this pull request as draft
September 6, 2022 09:07
github-actions
Bot
added
core
andygrove
reviewed
Sep 6, 2022
andygrove
left a comment
andygrove
left a comment
Member
There was a problem hiding this comment.
This is looking good so far. Nice simplification.
Signed-off-by: remzi <13716567376yh@gmail.com>
Signed-off-by: remzi <13716567376yh@gmail.com>
Signed-off-by: remzi <13716567376yh@gmail.com>
HaoYang670
marked this pull request as ready for review
September 7, 2022 02:18
Codecov Report
@@ Coverage Diff @@
## master #3374 +/- ##
==========================================
- Coverage 85.58% 85.58% -0.01%
==========================================
Files 296 296
Lines 54175 54158 -17
==========================================
- Hits 46364 46349 -15
+ Misses 7811 7809 -2
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
alamb
approved these changes
Sep 7, 2022
alamb
left a comment
alamb
left a comment
Contributor
There was a problem hiding this comment.
Looks good to me @HaoYang670 -- thanks!
fyi @turbo1912 and @AssHero and @
ming535 who have contributed to this code recently
| /// Maximum number of rows to fetch | ||
| pub skip: usize, | ||
| /// Maximum number of rows to fetch, | ||
| /// None means fetching all rows |
andygrove
approved these changes
Sep 7, 2022
|
Benchmark runs are scheduled for baseline = c359018 and contender = 43e2d91. 43e2d91 is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
jackwener
approved these changes
Sep 7, 2022
| _ => {} | ||
| return Ok(input.as_ref().clone()); | ||
| } else { | ||
| {} |
Member
|
😂Look like my review is late, new a PR for it |
lyne7-sc
pushed a commit
to lyne7-sc/datafusion
that referenced
this pull request
Aug 25, 2026
…oup (apache#24650) Bumps the all-uv-deps group with 1 update: [pygithub](https://github.com/pygithub/pygithub). Updates `pygithub` from 2.9.1 to 2.10.0 <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/pygithub/pygithub/releases">pygithub's releases</a>.</em></p> <blockquote> <h2>2.10.0</h2> <h3>Notable changes</h3> <h4>Drop Python 3.9 support due to End-of-Life</h4> <p>Python 3.9 reached its end-of-life October 31, 2025. Support has been removed with this release.</p> <h3>New Features</h3> <ul> <li>Allow to specify the Github API version by <a href="https://github.com/EnricoMi"><code>@EnricoMi</code></a> in <a href="https://redirect.github.com/PyGithub/PyGithub/pull/3480">PyGithub/PyGithub#3480</a></li> <li>Add issue dependency endpoints by <a href="https://github.com/james-geiger"><code>@james-geiger</code></a> in <a href="https://redirect.github.com/PyGithub/PyGithub/pull/3477">PyGithub/PyGithub#3477</a></li> </ul> <h3>Improvements</h3> <ul> <li>Add <code>incomplete_results</code> property to <code>PaginatedList</code> by <a href="https://github.com/Felixoid"><code>@Felixoid</code></a> in <a href="https://redirect.github.com/PyGithub/PyGithub/pull/3396">PyGithub/PyGithub#3396</a></li> <li>Add <code>WorkflowRun.get_attempt</code> and <code>Repository.get_workflow_job</code> functions by <a href="https://github.com/cecheta"><code>@cecheta</code></a> in <a href="https://redirect.github.com/PyGithub/PyGithub/pull/3401">PyGithub/PyGithub#3401</a></li> <li>Add support for <code>head_repo</code> when creating pull request by <a href="https://github.com/shannon"><code>@shannon</code></a> in <a href="https://redirect.github.com/PyGithub/PyGithub/pull/3479">PyGithub/PyGithub#3479</a></li> <li>Add <code>max_rate_limit_wait</code> to <code>GithubRetry</code> to cap rate limit backoff by <a href="https://github.com/tanistheta"><code>@tanistheta</code></a> in <a href="https://redirect.github.com/PyGithub/PyGithub/pull/3540">PyGithub/PyGithub#3540</a></li> <li>Add <code>return_run_details</code> parameter to <code>Workflow.create_dispatch</code> by <a href="https://github.com/SebastienSyd"><code>@SebastienSyd</code></a> in <a href="https://redirect.github.com/PyGithub/PyGithub/pull/3471">PyGithub/PyGithub#3471</a></li> <li>Update <code>SecurityAndAnalysis</code> by <a href="https://github.com/EnricoMi"><code>@EnricoMi</code></a> in <a href="https://redirect.github.com/PyGithub/PyGithub/pull/3503">PyGithub/PyGithub#3503</a></li> </ul> <h3>Bug Fixes</h3> <ul> <li>Fix duplicated URL in <code>OrganizationVariable.edit()</code> and <code>OrganizationSecret.edit()</code> by <a href="https://github.com/Krishnachaitanyakc"><code>@Krishnachaitanyakc</code></a> in <a href="https://redirect.github.com/PyGithub/PyGithub/pull/3472">PyGithub/PyGithub#3472</a></li> <li>Fix <code>GithubException.__str__</code> decoding bytes data by <a href="https://github.com/SAY-5"><code>@SAY-5</code></a> in <a href="https://redirect.github.com/PyGithub/PyGithub/pull/3494">PyGithub/PyGithub#3494</a></li> <li>Fixing <code>OrganizationVariable.value</code> by properly using base class by <a href="https://github.com/EnricoMi"><code>@EnricoMi</code></a> in <a href="https://redirect.github.com/PyGithub/PyGithub/pull/3507">PyGithub/PyGithub#3507</a></li> <li>Parse only the query string for <code>PaginatedList.totalCount</code> by <a href="https://github.com/Noethix55555"><code>@Noethix55555</code></a> in <a href="https://redirect.github.com/PyGithub/PyGithub/pull/3518">PyGithub/PyGithub#3518</a></li> <li>Encode boolean query parameters as lowercase by <a href="https://github.com/Noethix55555"><code>@Noethix55555</code></a> in <a href="https://redirect.github.com/PyGithub/PyGithub/pull/3516">PyGithub/PyGithub#3516</a></li> <li>Fix doubled slash in request path for <code>base_url</code> with trailing slash by <a href="https://github.com/Noethix55555"><code>@Noethix55555</code></a> in <a href="https://redirect.github.com/PyGithub/PyGithub/pull/3537">PyGithub/PyGithub#3537</a></li> <li>Fix <code>WorkflowRun</code> schema suggestion by <a href="https://github.com/EnricoMi"><code>@EnricoMi</code></a> in <a href="https://redirect.github.com/PyGithub/PyGithub/pull/3559">PyGithub/PyGithub#3559</a></li> <li>Fix OAuth2 authorization <code>state</code> / <code>code_verifier</code> parameters by <a href="https://github.com/TheoGoudout"><code>@TheoGoudout</code></a> in <a href="https://redirect.github.com/PyGithub/PyGithub/pull/3440">PyGithub/PyGithub#3440</a></li> <li>Allow creating custom property with <code>values_editable_by</code> param by <a href="https://github.com/chawlajay9"><code>@chawlajay9</code></a> in <a href="https://redirect.github.com/PyGithub/PyGithub/pull/3548">PyGithub/PyGithub#3548</a></li> <li>Fix <code>OrganizationSecret.edit()</code> to seal the value and use <code>PUT</code> by <a href="https://github.com/Noethix55555"><code>@Noethix55555</code></a> in <a href="https://redirect.github.com/PyGithub/PyGithub/pull/3529">PyGithub/PyGithub#3529</a></li> <li>Fix lazy retrieval of latest tag name by <a href="https://github.com/sathieu"><code>@sathieu</code></a> in <a href="https://redirect.github.com/PyGithub/PyGithub/pull/3487">PyGithub/PyGithub#3487</a></li> <li>Fix typing and typos by <a href="https://github.com/EnricoMi"><code>@EnricoMi</code></a> in <a href="https://redirect.github.com/PyGithub/PyGithub/pull/3485">PyGithub/PyGithub#3485</a></li> </ul> <h3>Maintenance</h3> <ul> <li>Add support for Python 3.15 and drop EOL 3.9 by <a href="https://github.com/hugovk"><code>@hugovk</code></a> in <a href="https://redirect.github.com/PyGithub/PyGithub/pull/3551">PyGithub/PyGithub#3551</a></li> <li>Move self-link awareness into <code>CompletableGithubObject</code> by <a href="https://github.com/EnricoMi"><code>@EnricoMi</code></a> in <a href="https://redirect.github.com/PyGithub/PyGithub/pull/3432">PyGithub/PyGithub#3432</a></li> <li>Add documentation for agents, add Claude skills by <a href="https://github.com/EnricoMi"><code>@EnricoMi</code></a> in <a href="https://redirect.github.com/PyGithub/PyGithub/pull/3509">PyGithub/PyGithub#3509</a></li> <li>Add <code>sphinx-copybutton</code> for code blocks by <a href="https://github.com/DivyanshiGautam31"><code>@DivyanshiGautam31</code></a> in <a href="https://redirect.github.com/PyGithub/PyGithub/pull/3493">PyGithub/PyGithub#3493</a></li> <li>Add support to OpenAPI script for applying schema to methods by <a href="https://github.com/EnricoMi"><code>@EnricoMi</code></a> in <a href="https://redirect.github.com/PyGithub/PyGithub/pull/3374">PyGithub/PyGithub#3374</a></li> <li>Improve OpenAPI apply properties and methods by <a href="https://github.com/EnricoMi"><code>@EnricoMi</code></a> in <a href="https://redirect.github.com/PyGithub/PyGithub/pull/3495">PyGithub/PyGithub#3495</a></li> <li>Fix OpenAPI method verb detection by <a href="https://github.com/EnricoMi"><code>@EnricoMi</code></a> in <a href="https://redirect.github.com/PyGithub/PyGithub/pull/3496">PyGithub/PyGithub#3496</a></li> <li>Add OpenAPI script tests by <a href="https://github.com/EnricoMi"><code>@EnricoMi</code></a> in <a href="https://redirect.github.com/PyGithub/PyGithub/pull/3489">PyGithub/PyGithub#3489</a></li> <li>Fix OpenAPI apply method by <a href="https://github.com/EnricoMi"><code>@EnricoMi</code></a> in <a href="https://redirect.github.com/PyGithub/PyGithub/pull/3498">PyGithub/PyGithub#3498</a></li> <li>Reordering OpenAPI test sequence by <a href="https://github.com/EnricoMi"><code>@EnricoMi</code></a> in <a href="https://redirect.github.com/PyGithub/PyGithub/pull/3500">PyGithub/PyGithub#3500</a></li> <li>Apply typing convention by <a href="https://github.com/EnricoMi"><code>@EnricoMi</code></a> in <a href="https://redirect.github.com/PyGithub/PyGithub/pull/3504">PyGithub/PyGithub#3504</a></li> <li>Bump <code>mypy</code> Python version to 3.12 by <a href="https://github.com/EnricoMi"><code>@EnricoMi</code></a> in <a href="https://redirect.github.com/PyGithub/PyGithub/pull/3505">PyGithub/PyGithub#3505</a></li> <li>Use <code>@overload</code> to type <code>get_user</code> by <a href="https://github.com/xmo-odoo"><code>@xmo-odoo</code></a> in <a href="https://redirect.github.com/PyGithub/PyGithub/pull/3502">PyGithub/PyGithub#3502</a></li> <li>Add overload type annotations by <a href="https://github.com/EnricoMi"><code>@EnricoMi</code></a> in <a href="https://redirect.github.com/PyGithub/PyGithub/pull/3506">PyGithub/PyGithub#3506</a></li> <li>Simplify <code>OrganizationVariable</code> by <a href="https://github.com/EnricoMi"><code>@EnricoMi</code></a> in <a href="https://redirect.github.com/PyGithub/PyGithub/pull/3508">PyGithub/PyGithub#3508</a></li> <li>Add OpenAPI script filename option to create class by <a href="https://github.com/EnricoMi"><code>@EnricoMi</code></a> in <a href="https://redirect.github.com/PyGithub/PyGithub/pull/3512">PyGithub/PyGithub#3512</a></li> <li>OpenAPI script improvements by <a href="https://github.com/EnricoMi"><code>@EnricoMi</code></a> in <a href="https://redirect.github.com/PyGithub/PyGithub/pull/3511">PyGithub/PyGithub#3511</a></li> </ul> <!-- raw HTML omitted --> </blockquote> <p>... (truncated)</p> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/PyGithub/PyGithub/blob/main/doc/changes.rst">pygithub's changelog</a>.</em></p> <blockquote> <h2>Version 2.10.0 (August 20, 2026)</h2> <p>Notable changes ^^^^^^^^^^^^^^^</p> <p>Drop Python 3.9 support due to End-of-Life """""""""""""""""""""""""""""""""""""""""" Python 3.9 reached its end-of-life October 31, 2025. Support has been removed with this release.</p> <p>New Features ^^^^^^^^^^^^</p> <ul> <li>Allow to specify the Github API version (<code>[apache#3480](PyGithub/PyGithub#3480) <https://github.com/PyGithub/PyGithub/pull/3480></code><em>) (<code>546b0ee7e <https://github.com/PyGithub/PyGithub/commit/546b0ee7e></code></em>)</li> <li>Add issue dependency endpoints (<code>[apache#3477](PyGithub/PyGithub#3477) <https://github.com/PyGithub/PyGithub/pull/3477></code><em>) (<code>b0ee6e0c7 <https://github.com/PyGithub/PyGithub/commit/b0ee6e0c7></code></em>)</li> </ul> <p>Improvements ^^^^^^^^^^^^</p> <ul> <li>Add <code>incomplete_results</code> property to <code>PaginatedList</code> (<code>[apache#3396](PyGithub/PyGithub#3396) <https://github.com/PyGithub/PyGithub/pull/3396></code><em>) (<code>7806e7dcc <https://github.com/PyGithub/PyGithub/commit/7806e7dcc></code></em>)</li> <li>Add <code>WorkflowRun.get_attempt</code> and <code>Repository.get_workflow_job</code> functions (<code>[apache#3401](PyGithub/PyGithub#3401) <https://github.com/PyGithub/PyGithub/pull/3401></code><em>) (<code>fdf9ed869 <https://github.com/PyGithub/PyGithub/commit/fdf9ed869></code></em>)</li> <li>Add support for <code>head_repo</code> when creating pull request (<code>[apache#3479](PyGithub/PyGithub#3479) <https://github.com/PyGithub/PyGithub/pull/3479></code><em>) (<code>8ddfd6b11 <https://github.com/PyGithub/PyGithub/commit/8ddfd6b11></code></em>)</li> <li>Add <code>max_rate_limit_wait</code> to <code>GithubRetry</code> to cap rate limit backoff (<code>[apache#3540](PyGithub/PyGithub#3540) <https://github.com/PyGithub/PyGithub/pull/3540></code><em>) (<code>8b50a098f <https://github.com/PyGithub/PyGithub/commit/8b50a098f></code></em>)</li> <li>Add <code>return_run_details</code> parameter to <code>Workflow.create_dispatch</code> (<code>[apache#3471](PyGithub/PyGithub#3471) <https://github.com/PyGithub/PyGithub/pull/3471></code><em>) (<code>162ce9d0e <https://github.com/PyGithub/PyGithub/commit/162ce9d0e></code></em>)</li> <li>Update <code>SecurityAndAnalysis</code> (<code>[apache#3503](PyGithub/PyGithub#3503) <https://github.com/PyGithub/PyGithub/pull/3503></code><em>) (<code>9674c5799 <https://github.com/PyGithub/PyGithub/commit/9674c5799></code></em>)</li> </ul> <p>Bug Fixes ^^^^^^^^^</p> <ul> <li>Fix duplicated URL in <code>OrganizationVariable.edit()</code> and <code>OrganizationSecret.edit()</code> (<code>[apache#3472](PyGithub/PyGithub#3472) <https://github.com/PyGithub/PyGithub/pull/3472></code><em>) (<code>a2e76eb8e <https://github.com/PyGithub/PyGithub/commit/a2e76eb8e></code></em>)</li> <li>Fix <code>GithubException.__str__</code> decoding bytes data (<code>[apache#3494](PyGithub/PyGithub#3494) <https://github.com/PyGithub/PyGithub/pull/3494></code><em>) (<code>7a3b22ed6 <https://github.com/PyGithub/PyGithub/commit/7a3b22ed6></code></em>)</li> <li>Fixing <code>OrganizationVariable.value</code> by properly using base class (<code>[apache#3507](PyGithub/PyGithub#3507) <https://github.com/PyGithub/PyGithub/pull/3507></code><em>) (<code>39a7464ff <https://github.com/PyGithub/PyGithub/commit/39a7464ff></code></em>)</li> <li>Parse only the query string for <code>PaginatedList.totalCount</code> (<code>[apache#3518](PyGithub/PyGithub#3518) <https://github.com/PyGithub/PyGithub/pull/3518></code><em>) (<code>645d2a2e8 <https://github.com/PyGithub/PyGithub/commit/645d2a2e8></code></em>)</li> <li>Encode boolean query parameters as lowercase (<code>[apache#3516](PyGithub/PyGithub#3516) <https://github.com/PyGithub/PyGithub/pull/3516></code><em>) (<code>f4e29299e <https://github.com/PyGithub/PyGithub/commit/f4e29299e></code></em>)</li> <li>Fix doubled slash in request path for <code>base_url</code> with trailing slash (<code>[apache#3537](PyGithub/PyGithub#3537) <https://github.com/PyGithub/PyGithub/pull/3537></code><em>) (<code>c15572f23 <https://github.com/PyGithub/PyGithub/commit/c15572f23></code></em>)</li> <li>Fix <code>WorkflowRun</code> schema suggestion (<code>[apache#3559](PyGithub/PyGithub#3559) <https://github.com/PyGithub/PyGithub/pull/3559></code><em>) (<code>5f707d64b <https://github.com/PyGithub/PyGithub/commit/5f707d64b></code></em>)</li> <li>Fix OAuth2 authorization <code>state</code> / <code>code_verifier</code> parameters (<code>[apache#3440](PyGithub/PyGithub#3440) <https://github.com/PyGithub/PyGithub/pull/3440></code><em>) (<code>4785224bc <https://github.com/PyGithub/PyGithub/commit/4785224bc></code></em>)</li> <li>Allow creating custom property with <code>values_editable_by</code> param (<code>[apache#3548](PyGithub/PyGithub#3548) <https://github.com/PyGithub/PyGithub/pull/3548></code><em>) (<code>134f38a63 <https://github.com/PyGithub/PyGithub/commit/134f38a63></code></em>)</li> <li>Fix <code>OrganizationSecret.edit()</code> to seal the value and use <code>PUT</code> (<code>[apache#3529](PyGithub/PyGithub#3529) <https://github.com/PyGithub/PyGithub/pull/3529></code><em>) (<code>4f8674b72 <https://github.com/PyGithub/PyGithub/commit/4f8674b72></code></em>)</li> <li>Fix lazy retrieval of latest tag name (<code>[apache#3487](PyGithub/PyGithub#3487) <https://github.com/PyGithub/PyGithub/pull/3487></code><em>) (<code>33071b35d <https://github.com/PyGithub/PyGithub/commit/33071b35d></code></em>)</li> <li>Fix typing and typos (<code>[apache#3485](PyGithub/PyGithub#3485) <https://github.com/PyGithub/PyGithub/pull/3485></code><em>) (<code>fd7abf6a7 <https://github.com/PyGithub/PyGithub/commit/fd7abf6a7></code></em>)</li> </ul> <p>Maintenance ^^^^^^^^^^^</p> <ul> <li>Add support for Python 3.15 and drop EOL 3.9 (<code>[apache#3551](PyGithub/PyGithub#3551) <https://github.com/PyGithub/PyGithub/pull/3551></code><em>) (<code>5e2de3144 <https://github.com/PyGithub/PyGithub/commit/5e2de3144></code></em>)</li> <li>Move self-link awareness into <code>CompletableGithubObject</code> (<code>[apache#3432](PyGithub/PyGithub#3432) <https://github.com/PyGithub/PyGithub/pull/3432></code><em>) (<code>92ec3fab0 <https://github.com/PyGithub/PyGithub/commit/92ec3fab0></code></em>)</li> <li>Add documentation for agents, add Claude skills (<code>[apache#3509](PyGithub/PyGithub#3509) <https://github.com/PyGithub/PyGithub/pull/3509></code><em>) (<code>28f140d10 <https://github.com/PyGithub/PyGithub/commit/28f140d10></code></em>)</li> <li>Add <code>sphinx-copybutton</code> for code blocks (<code>[apache#3493](PyGithub/PyGithub#3493) <https://github.com/PyGithub/PyGithub/pull/3493></code>_)</li> <li>Add support to OpenAPI script for applying schema to methods (<code>[apache#3374](PyGithub/PyGithub#3374) <https://github.com/PyGithub/PyGithub/pull/3374></code><em>) (<code>b7a6d2324 <https://github.com/PyGithub/PyGithub/commit/b7a6d2324></code></em>)</li> <li>Improve OpenAPI apply properties and methods (<code>[apache#3495](PyGithub/PyGithub#3495) <https://github.com/PyGithub/PyGithub/pull/3495></code>_)</li> <li>Fix OpenAPI method verb detection (<code>[apache#3496](PyGithub/PyGithub#3496) <https://github.com/PyGithub/PyGithub/pull/3496></code>_)</li> <li>Add OpenAPI script tests (<code>[apache#3489](PyGithub/PyGithub#3489) <https://github.com/PyGithub/PyGithub/pull/3489></code><em>) (<code>09242d9b0 <https://github.com/PyGithub/PyGithub/commit/09242d9b0></code></em>)</li> <li>Fix OpenAPI apply method (<code>[apache#3498](PyGithub/PyGithub#3498) <https://github.com/PyGithub/PyGithub/pull/3498></code><em>) (<code>8f8697235 <https://github.com/PyGithub/PyGithub/commit/8f8697235></code></em>)</li> </ul> <!-- raw HTML omitted --> </blockquote> <p>... (truncated)</p> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/PyGithub/PyGithub/commit/5cdf6ab395c52efb652d0bc1f28fdf2e452b1b41"><code>5cdf6ab</code></a> Release 2.10.0 (<a href="https://redirect.github.com/pygithub/pygithub/issues/3560">#3560</a>)</li> <li><a href="https://github.com/PyGithub/PyGithub/commit/33071b35d01033f5c059c7db02806710a7819330"><code>33071b3</code></a> Fix lazy retrieval of latest tag name (<a href="https://redirect.github.com/pygithub/pygithub/issues/3487">#3487</a>)</li> <li><a href="https://github.com/PyGithub/PyGithub/commit/4f8674b724f9c0bbeac36a78cbf5f7fc577b9bf2"><code>4f8674b</code></a> Fix OrganizationSecret.edit() to seal the value and use PUT (<a href="https://redirect.github.com/pygithub/pygithub/issues/3529">#3529</a>)</li> <li><a href="https://github.com/PyGithub/PyGithub/commit/c63d09e261b627b3f8ce6777038ed818a86d73b4"><code>c63d09e</code></a> docs: add example for uploading multiple files in a single commit (<a href="https://redirect.github.com/pygithub/pygithub/issues/3545">#3545</a>)</li> <li><a href="https://github.com/PyGithub/PyGithub/commit/4785224bc5089d0fd7933367d7f9fc0171d2d8d8"><code>4785224</code></a> Fix OAuth2 authorization <code>state</code> / <code>code_verifier</code> parameters (<a href="https://redirect.github.com/pygithub/pygithub/issues/3440">#3440</a>)</li> <li><a href="https://github.com/PyGithub/PyGithub/commit/134f38a63dbcf0161ecd7df30e398f24f14e9fad"><code>134f38a</code></a> Allow creating custom property with values_editable_by param (<a href="https://redirect.github.com/pygithub/pygithub/issues/3548">#3548</a>)</li> <li><a href="https://github.com/PyGithub/PyGithub/commit/5f707d64b86d63b66820ed3941785fa803476625"><code>5f707d6</code></a> Fix <code>WorkflowRun</code> schema suggestion (<a href="https://redirect.github.com/pygithub/pygithub/issues/3559">#3559</a>)</li> <li><a href="https://github.com/PyGithub/PyGithub/commit/82809291e065be02354a9673750a8ae35d363bdd"><code>8280929</code></a> docs: add exception handling example (<a href="https://redirect.github.com/pygithub/pygithub/issues/3543">#3543</a>)</li> <li><a href="https://github.com/PyGithub/PyGithub/commit/c15572f23aa4743efe4b1f88bd26ddfb0c46acf8"><code>c15572f</code></a> Fix doubled slash in request path for <code>base_url</code> with trailing slash (<a href="https://redirect.github.com/pygithub/pygithub/issues/3537">#3537</a>)</li> <li><a href="https://github.com/PyGithub/PyGithub/commit/162ce9d0ed69b9e4950c92e1896ab3539a9cba1a"><code>162ce9d</code></a> Add <code>return_run_details</code> parameter to <code>Workflow.create_dispatch</code> (<a href="https://redirect.github.com/pygithub/pygithub/issues/3471">#3471</a>)</li> <li>Additional commits viewable in <a href="https://github.com/pygithub/pygithub/compare/v2.9.1...v2.10.0">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore <dependency name> major version` will close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself) - `@dependabot ignore <dependency name> minor version` will close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself) - `@dependabot ignore <dependency name>` will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself) - `@dependabot unignore <dependency name>` will remove all of the ignore conditions of the specified dependency - `@dependabot unignore <dependency name> <ignore condition>` will remove the ignore condition of the specified dependency and ignore conditions </details> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: remzi 13716567376yh@gmail.com
Which issue does this PR close?
Closes #3369.
Rationale for this change
skip = Noneandskip = Some(0)are equivalent, so we don't need both of them and theOptionaltype here is redundant. We useusizeas the type ofskipso thatskip = Noneandskip = Some(0)can be simplified toskip = 0What changes are included in this PR?
Are there any user-facing changes?
Yes.