Skip to content

add spring boot interceptor to copy header(dubbo-tag)/cookie(dubbo.tag)#12514

Merged
AlbumenJ merged 8 commits intoapache:3.3from
carlvine500:3.2-copy-tag
Jun 28, 2023
Merged

add spring boot interceptor to copy header(dubbo-tag)/cookie(dubbo.tag)#12514
AlbumenJ merged 8 commits intoapache:3.3from
carlvine500:3.2-copy-tag

Conversation

@carlvine500
Copy link
Contributor

@carlvine500 carlvine500 commented Jun 13, 2023

What is the purpose of the change

copy header(dubbo-tag)/cookie(dubbo.tag) to dubbo context

document:
https://github.com/carlvine500/dubbo/blob/3.2/dubbo-spring-boot/dubbo-spring-boot-interceptor/README.md

Checklist

  • Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Add some description to dubbo-website project if you are requesting to add a feature.
  • GitHub Actions works fine on your own branch.
  • If this contribution is large, please follow the Software Donation Guide.
@carlvine500
Copy link
Contributor Author

@songxiaosheng 请求大神协助, 分析下为何这个步骤总是失败: Build and Test For PR / Unit Test On ubuntu-latest (pull_request)

@AlbumenJ
Copy link
Member

image

@carlvine500
Copy link
Contributor Author

image

ok , I will fix it .

@codecov-commenter
Copy link

codecov-commenter commented Jun 18, 2023

Codecov Report

Merging #12514 (f91dd5d) into 3.2 (8ad792c) will decrease coverage by 0.28%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##                3.2   #12514      +/-   ##
============================================
- Coverage     69.60%   69.32%   -0.28%     
+ Complexity      116        2     -114     
============================================
  Files          3496     1627    -1869     
  Lines        165276    67325   -97951     
  Branches      27566     9876   -17690     
============================================
- Hits         115045    46676   -68369     
+ Misses        40229    16137   -24092     
+ Partials      10002     4512    -5490     

see 1918 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@carlvine500
Copy link
Contributor Author

@songxiaosheng 如下这一步骤是需要重新触发吗? 看起来好像是超时了 .
Build and Test For PR / jacoco-result-merge (pull_request)

@songxiaosheng
Copy link
Member

@songxiaosheng 如下这一步骤是需要重新触发吗? 看起来好像是超时了 . Build and Test For PR / jacoco-result-merge (pull_request)

rerun is ok

@AlbumenJ AlbumenJ changed the base branch from 3.2 to 3.3 June 28, 2023 12:29
Copy link
Member

@AlbumenJ AlbumenJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a feature and I have change it to 3.3 branch

@AlbumenJ AlbumenJ merged commit 27e6838 into apache:3.3 Jun 28, 2023
@sonarqubecloud
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

4 participants