Migrate tests to JUnit5#14922
Merged
CrazyHZM merged 2 commits intoapache:3.3from Nov 23, 2024
strangelookingnerd:migrate_to_junit5
Merged
Migrate tests to JUnit5#14922CrazyHZM merged 2 commits intoapache:3.3from strangelookingnerd:migrate_to_junit5
CrazyHZM merged 2 commits intoapache:3.3from
strangelookingnerd:migrate_to_junit5
Conversation
Contributor
|
LGTM |
Contributor
Contributor
Author
Seems like I missed that one, sorry for that. However to me it seems like this test should have failed without my changes as well. I noticed that there is an exact copy of the failing test which has the assertion that is causing the issue here is commented out Edit: I just confirmed that the test that is failing was simply not executed before my changes. Digging a little deeper I found #12861 which suggests that the property that is checked here caused some kind of issue. I therefore propose to give the test the same treatment as in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Most of the tests already use JUnit5. This PR will migrate the missing tests and remove the
junit-jupiter-vintageas well asjunitdependencies.Migration includes:
Assertionspublicmodifiers from test classes and methodsexpectedandactual, simplyifing assertions...)I validated my changes using
./build -t.Checklist