Skip to content

fix repeat load registryFactory#15221

Merged
AlbumenJ merged 2 commits intoapache:3.3from
RainYuY:fix-double-load-registry-factory
Mar 11, 2025
Merged

fix repeat load registryFactory#15221
AlbumenJ merged 2 commits intoapache:3.3from
RainYuY:fix-double-load-registry-factory

Conversation

@RainYuY
Copy link
Member

@RainYuY RainYuY commented Mar 8, 2025

What is the purpose of the change?

Checklist

  • Make sure there is a GitHub_issue field for the change.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Make sure gitHub actions can pass. Why the workflow is failing and how to fix it?
@RainYuY
Copy link
Member Author

RainYuY commented Mar 8, 2025

PTAL @AlbumenJ

@codecov-commenter
Copy link

codecov-commenter commented Mar 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.79%. Comparing base (3e5216f) to head (6a4ab32).

Additional details and impacted files
@@            Coverage Diff            @@
##                3.3   #15221   +/-   ##
=========================================
  Coverage     60.78%   60.79%           
- Complexity    10890    10896    +6     
=========================================
  Files          1885     1885           
  Lines         86072    86069    -3     
  Branches      12892    12892           
=========================================
+ Hits          52319    52322    +3     
+ Misses        28306    28303    -3     
+ Partials       5447     5444    -3     
Flag Coverage Δ
integration-tests 33.14% <ø> (+0.06%) ⬆️
samples-tests 29.22% <ø> (+0.02%) ⬆️
unit-tests 58.90% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
@AlbumenJ AlbumenJ merged commit cad36ee into apache:3.3 Mar 11, 2025
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants