[3.3] Add http2 client connection preface process#15436
Merged
zrlw merged 2 commits intoapache:3.3from Jun 9, 2025
Merged
Conversation
4 tasks
Contributor
Author
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## 3.3 #15436 +/- ##
============================================
+ Coverage 60.90% 60.91% +0.01%
- Complexity 11423 11440 +17
============================================
Files 1887 1888 +1
Lines 86266 86309 +43
Branches 12929 12933 +4
============================================
+ Hits 52540 52576 +36
- Misses 28290 28291 +1
- Partials 5436 5442 +6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
oxsean
approved these changes
Jun 9, 2025
| protected void doConnect() throws RemotingException { | ||
| long start = System.currentTimeMillis(); | ||
| super.doConnect(); | ||
| if (connectionPrefaceReceivedPromiseRef == null) { |
Contributor
There was a problem hiding this comment.
Please extract this logic into a separate method, and in the comment, reference RFC7540#section-3.5 to explain why we need this.
Contributor
|
LGTM. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change?
submit pr again for #15368 which has been reverted because it has defects should be fixed: connectionPrefaceReceivedPromise should be created before calling performConnect, otherwise no promise could be set if server http2settings frame was received before this preparation.
try to fix #15233

No provider availableissue, the roots of the issue is client sent large headers frame before receiving server connection preface (http2 settings frame), which cause server sent back go away frame and the connection was disconnected by the server.see details at https://httpwg.org/specs/rfc7540.html#ConnectionHeader
https://quafoo.gitbooks.io/http2-rfc7540-zh-cn-en/content/chapter3/section3.5.html
Checklist