[FLINK-39977][runtime] Recovery of merged channel state handles - #29043
Open
Zakelly wants to merge 2 commits into
Open
[FLINK-39977][runtime] Recovery of merged channel state handles#29043Zakelly wants to merge 2 commits into
Zakelly wants to merge 2 commits into
Conversation
Collaborator
Generated-by: OpenAI Codex (GPT-5.6 Sol)
Contributor
Author
|
@1996fanrui Would you please take a look? |
1996fanrui
reviewed
Aug 30, 2026
1996fanrui
left a comment
Member
There was a problem hiding this comment.
Hey @Zakelly , thanks for the pr! I will take a look next week
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
This pull request fixes recovery from checkpoints containing channel state written by the unified file-merging mechanism.
During recovery, the file-merging snapshot manager previously restored keyed and operator state handles but ignored channel state handles. Consequently, merged files referenced by input channel state, upstream output buffer state, or result subpartition state were not restored into the file-merging snapshot manager's tracking information.
Brief change log
FileMergingChannelStateITCaseto verify recovery after replacing all TaskManagers.Verifying this change
This change added and extended tests and can be verified as follows:
FileMergingChannelStateITCase, which:SegmentFileStateHandle.FileMergingSnapshotManagerTestBaseto verify that input channel, upstream output buffer, and result subpartition state handles are restored and tracked without duplicating shared delegates.FileMergingChannelStateITCasesuccessfully; it completed in approximately 22 seconds locally.Does this pull request potentially affect one of the following parts:
@Public(Evolving): noDocumentation
Was generative AI tooling used to co-author this PR?
Generated-by: OpenAI Codex (GPT-5.6 Sol)