[FLINK-40518][checkpointing] Only enable checkpointing-during-recovery when unaligned checkpoints are enabled - #29055
Open
1996fanrui wants to merge 1 commit into
Open
[FLINK-40518][checkpointing] Only enable checkpointing-during-recovery when unaligned checkpoints are enabled#290551996fanrui wants to merge 1 commit into
1996fanrui wants to merge 1 commit into
Conversation
…y when unaligned checkpoints are enabled
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
CheckpointingOptions.isCheckpointingDuringRecoveryEnabledgated only onUNALIGNED_RECOVER_OUTPUT_ON_DOWNSTREAMandCHECKPOINTING_DURING_RECOVERY_ENABLED, not on whetherunaligned checkpoints are enabled. But checkpointing during recovery only works on the unaligned
(
alternating()) barrier-handler path; with unaligned checkpoints disabled the aligned path gets a NO_OPrecovery trigger, so a checkpoint triggered mid-recovery can neither be taken nor declined and hangs until
it expires, leading to a failover loop. This adds the missing precondition so such jobs fall back to the
tested non-CDR recovery path.
Brief change log
CheckpointingOptions#isCheckpointingDuringRecoveryEnabled(the single central gate for all CDR call sites).Verifying this change
This change added a unit test:
CheckpointingOptionsTestto assert CDR requires unaligned checkpoints enabled (and is disabled otherwise).Does this pull request potentially affect one of the following parts:
@Public(Evolving): noDocumentation
Was generative AI tooling used to co-author this PR?