[FLINK-40530][runtime-web] Isolate per-entry failures in job overview aggregation - #29062
Open
argoyal2212 wants to merge 1 commit into
Open
[FLINK-40530][runtime-web] Isolate per-entry failures in job overview aggregation#29062argoyal2212 wants to merge 1 commit into
argoyal2212 wants to merge 1 commit into
Conversation
… aggregation A single malformed archive no longer aborts the whole /jobs/overview update; it is skipped and logged, and a good overview is kept if all entries fail.
Contributor
Author
|
@zentol @gaborgsomogyi @dmvk Can I please get some help on this PR review. Thanks! |
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
HistoryServerArchiveFetcher#updateJobOverview()aggregates every archived job's overview JSON into one combined/jobs/overviewresponse. Today a single malformed or version-incompatible archive throws during aggregation and aborts the whole update, silently returning empty/stale overview data for every job, not just the offending one. This PR adds per-entry isolation so one bad archive can no longer take down the entire job listing.Brief change log
updateJobOverview()now catches and skips a single archive's parse failure instead of letting it abort the whole aggregationVerifying this change
This change added tests and can be verified as follows:
testUpdateJobOverviewSkipsMalformedEntryInsteadOfFailingEverything, which injects one malformed per-job overview entry alongside a valid one and asserts the valid job is still listedtestUpdateJobOverviewDoesNotWipeGoodOverviewWhenAllEntriesAreMalformed, which corrupts the only entry and asserts the previously written combined overview is preserved rather than replaced with an empty oneDoes this pull request potentially affect one of the following parts:
@Public(Evolving): noDocumentation
Was generative AI tooling used to co-author this PR?
Generated-by: GitHub Copilot CLI