Skip to content

perf(rust): optimize set_bytes with direct copy_nonoverlapping #3102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
borngraced wants to merge 1 commit into
base: main
Choose a base branch
from
Open

perf(rust): optimize set_bytes with direct copy_nonoverlapping #3102

borngraced wants to merge 1 commit into from

Conversation

@borngraced
Copy link

@borngraced borngraced commented Dec 30, 2025

Why?

All set_bytes callers follow the same pattern: save writer.len() as offset, write placeholder bytes (via write_*/skip), then call set_bytes to back-fill. Since bounds are already guaranteed by this usage pattern, the runtime checks are redundant I guess. This allows us to optimize them away while keeping a debug_assert! for safety...

What does this PR do?

Replace bounds-checked get_mut().unwrap().copy_from_slice() with direct ptr::copy_nonoverlapping.

  • Does this PR introduce any public API change?
  • Does this PR introduce any binary protocol compatibility change?

Benchmark

No benchmarks yet, but the improvement should be noticeable: https://godbolt.org/z/75bhPWxfW
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

1 participant

@borngraced