fix: improve error handling in searchVectorIndex method#750
Open
SYaoJun wants to merge 2 commits intoapache:masterfrom
Open
fix: improve error handling in searchVectorIndex method#750SYaoJun wants to merge 2 commits intoapache:masterfrom
SYaoJun wants to merge 2 commits intoapache:masterfrom
Conversation
Leomrlin
requested changes
Mar 2, 2026
Contributor
Leomrlin
left a comment
Leomrlin
left a comment
There was a problem hiding this comment.
A minor comment may need adjustment. Could you please take a look when you have time? Thanks!
| try { | ||
| reader.close(); | ||
| } catch (IOException e) { | ||
| throw new RuntimeException("Failed to close IndexReader", e); |
Contributor
There was a problem hiding this comment.
With this change, the exception from reader.close() could mask the original exception.
Contributor
Author
There was a problem hiding this comment.
With this change, the exception from
reader.close()could mask the original exception.
Thanks for the suggestions. Refactored resource management to use try-with-resources, eliminating the risk of suppressed exceptions during IndexReader closure.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ensure IndexReader is closed properly
What changes were proposed in this pull request?
How was this PR tested?