Skip to content

Switch some files to use future annotations, follow ruff guidance to … #1108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
flavour wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Switch some files to use future annotations, follow ruff guidance to … #1108

flavour wants to merge 2 commits into from

Conversation

@flavour
Copy link
Contributor

@flavour flavour commented Aug 28, 2024 •
edited
Loading

Better to look forward than back & hence use modern-style Type Hints.

Easier for new contributors if Ruff errors fixed rather than appearing when not due to their changes.

Changes

Added pyupgrade pre-commit hook to help migrate the old-style type-hints.

How I tested this

Relying on Unit Tests currently

Notes

Checklist

  • PR has an informative and human-readable title (this will be pulled into the release notes)
  • Changes are limited to a single goal (no scope creep)
  • Code passed the pre-commit check & code is left cleaner/nicer than when first encountered.
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future TODOs are captured in comments
  • Project documentation has been updated if adding/changing functionality.
Dev-iL
Dev-iL reviewed Aug 28, 2024
View reviewed changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@flavour @Dev-iL