Skip to content

MINOR: Cleanups in Connect #20077

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from
Open

MINOR: Cleanups in Connect #20077

wants to merge 1 commit into from
+102 −189

Conversation

mimaison
Copy link
Member

@mimaison mimaison commented Jul 1, 2025 •
edited by github-actions bot
Loading

A few cleanups including Java 17 syntax, collections and assertEquals()
order
Yunyung
Yunyung reviewed Jul 1, 2025
View reviewed changes
Copy link
Collaborator

@Yunyung Yunyung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. We can do more cleanups:

  1. replace Collections.xxx with List.of(), Set.of(), and Map.of().
  2. replace Arrays.asList() with List.of().
    Or do this in another PR as a follow-up.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
connect mirror-maker-2
2 participants
@mimaison @Yunyung