Skip to content

Consistent handling of HTTP/S proxy environment variables #2079

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
davidwegs wants to merge 1 commit into
base: trunk
Choose a base branch
from
Open

Consistent handling of HTTP/S proxy environment variables #2079

davidwegs wants to merge 1 commit into from

Conversation

@davidwegs
Copy link

@davidwegs davidwegs commented Nov 12, 2025

Consistent handling of HTTP/S proxy environment variables

Description

This PR provides consistent handling of the http_proxy, https_proxy, and no_proxy environment variables in line with the behavior of the Requests python library. Previously no_proxy wasn't being respected (#2077).

This is done by removing explicit handling of the http_proxy and https_proxy env variables in favor of downstream handling through the Requests library. Explicitly provided proxy settings through the proxy_url argument to the connection class and through the set_http_proxy method are still supported and still take precedence over the environment variables.

Status

done, ready for review

Checklist (tick everything that applies)

  • Code linting (required, can be done after the PR checks)
  • Documentation
  • Tests
  • ICLA (required for bigger changes)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

1 participant

@davidwegs