[FLUME-3468] fix default value of passwordFile property when userName is set for jms source - #405
Open
nikita15p wants to merge 1 commit into
Open
[FLUME-3468] fix default value of passwordFile property when userName is set for jms source#405nikita15p wants to merge 1 commit into
nikita15p wants to merge 1 commit into
Conversation
… is set for jms source
Contributor
Author
|
@rgoers can u please review this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In jms source, when passwordFile property in agent config is not set, currently null value is getting passed which causes exception due to
password = Optional.absent();in https://github.com/apache/flume/blob/trunk/flume-ng-sources/flume-jms-source/src/main/java/org/apache/flume/source/jms/JMSSource.java#L173.This PR, sets default value to empty string in case passwordFile property is not set.