Skip to content

fix(skill-evals): issue-reassess is the only shipped skill without an eval suite #1138

Description

@dpol1

What

skills/issue-reassess/ is the only one of the 71 shipped skills with no behavioural eval suite — there is no tools/skill-evals/evals/issue-reassess/ directory. (The 71st entry under evals/, non-asf-profile-smoke, is a profile smoke, not a skill suite.)

comm -23 <(ls skills | grep -v pyproject | sort) \
         <(ls tools/skill-evals/evals | sort)
# issue-reassess

The validator already knows:

skills/issue-reassess/SKILL.md  (1 warning)
  eval-coverage: no eval suite at tools/skill-evals/evals/issue-reassess/ — add one before shipping

Why it matters

AGENTS.md is explicit: "ship a behavioural eval suite under tools/skill-evals/evals/<skill-name>/ […] A skill PR without a matching eval suite is incomplete." The skill shipped anyway and is in active use — it has a row in the docs/mode-economics.md Triage table — so regressions in its classification and aggregation behaviour are currently invisible. The eval-coverage check (#9) is deliberately SOFT so in-flight eval PRs don't fail the gate, which means this gap stays silent until the skill misbehaves in front of a user.

Suggested fix

Add the suite. The skill's surfaces look directly fixturable: the per-issue verdict flow (skills/issue-reassess/per-issue-flow.md), pool selection (pool-selection.md), and verdict aggregation (verdict-aggregation.md). The sibling issue-reassess-stats suite (step-1-fetch-verdicts / step-2-classify / step-3-aggregate) is the natural model, and it already contains reassess-shaped fixture reports to crib from.

Related

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions