fix(spec-validator): add dev dependency group and fix check-#9 comment - #560
Merged
Merged
Conversation
…comment Add [dependency-groups] dev = [pytest, ruff] to tools/spec-validator/pyproject.toml so that the standard monorepo invocation uv run --project tools/spec-validator --group dev pytest tools/spec-validator/tests/ works from the repo root, matching the pattern established by tools/skill-and-tool-validator (asf-coupling-lint) and documented in the module docstring. Also fix a copy-paste comment mislabelling check apache#9 (validation-path existence as check apache#8 — SPDX header validation is check apache#8. Generated-by: Claude (Opus 4.7) EOF )
potiuk
approved these changes
Jun 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add [dependency-groups] dev = [pytest, ruff] to
tools/spec-validator/pyproject.toml so that the standard monorepo invocation
uv run --project tools/spec-validator --group dev pytest tools/spec-validator/tests/
works from the repo root, matching the pattern established by tools/skill-and-tool-validator (asf-coupling-lint) and documented in the module docstring.
Also fix a copy-paste comment mislabelling check #9 (validation-path existence as check #8 — SPDX header validation is check #8.
Generated-by: Claude (Opus 4.7)
Type of change
.claude/skills/<name>/) — eval fixtures updated belowtools/<system>/*.md)tools/*/withpyproject.toml)docs/,README.md,CONTRIBUTING.md)projects/_template/)prek, workflows, validators)Test plan
prek run --all-filespassesuv run pytest/ruff check/mypypasses(
PYTHONPATH=tools/skill-evals/src python3 -m skill_evals.runner tools/skill-evals/evals/<skill>/)(a regression test for the bug fixed / the behaviour added — see CONTRIBUTING.md)