Skip to content

Fix row and column ranges after sheet rename #524

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
avl93 wants to merge 2 commits into
base: trunk
Choose a base branch
from
Draft

Fix row and column ranges after sheet rename #524

avl93 wants to merge 2 commits into from

Conversation

@avl93
Copy link

@avl93 avl93 commented Sep 21, 2023

After renaming sheet, row and column ranges are being converted to cell ranges, like this:

before        -> after 
sheet2!$2:$4  -> sheet2!$A$2:$XFD$4
sheet2!$B:$C  -> sheet2!B:C

This fix changes some logic regarding updating ranges and formulas, also, it fixes TODO in TestHSSFName#testRepeatingRowsAndColumnsNames, referring the same problem.
@avl93 avl93 marked this pull request as draft September 22, 2023 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

1 participant

@avl93