XWPF Themes: allow public access of theme and add helpers for theme fonts #986
+58
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
I'd like to better support DOCX theme fonts, but currently they are inaccessible.
For anyone interested, a run can define fonts either
w:ascii="Times New Roman"w:asciiTheme="majorBidi"Currently the XWPFTheme doesn't expose major/minor fonts to resolve theme fonts, so I am fixing that in this PR.
Note: I spent a bit of time figuring out how the theme fonts are resolved and although it isn't implemented in this PR I thought I'd write it down somewhere. So for anyone interested, a run might look like this:
With settings containing
And a Theme like this:
This theme font can be interpreted by combining info from the document settings (
themeFontLang) and themes. There is an explanation of that in the spec at17.15.1.88 themeFontLang (Theme Font Languages). However that explanation doesn't really tell you how to map the locale code (for examplear-SA) fromthemeFontLangto a script (for exampleArab).I found that:
LocaleID.lookupByLanguageTag(localeName)can read the locale.localeID.getLcid()to a script. We can then lookup the major/minor theme font with that script