Skip to content

Conversation

@LiJie20190102
Copy link
Contributor

Purpose of this pull request

Filnk engine supports task restore from checkpoint upon startup, and issue is #10220

Does this PR introduce any user-facing change?

How was this patch tested?

Check list

@github-actions github-actions bot added the core SeaTunnel core module label Dec 23, 2025
@davidzollo
Copy link
Contributor

@yzeng1618 Please help review this PR, thx

+ "kubernetes-session, yarn-application, kubernetes-application]")
private MasterType masterType;

/** restore checkpoint path */
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment is inconsistent with the actual description of the savepoint parameter.

@Parameter(
names = {"-s", "--fromSavepoint"},
description =
"Path to a savepoint to restore the job from (for example, flink run -s hdfs:///flink/checkpoints/3c298a925d9a2a7837bbf5a8e4966b4f/chk-7902).")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The example describes a checkpoint, which is also inconsistent

@yzeng1618
Copy link
Contributor

Could we separately add descriptions for checkpoint and savepoint, and update the corresponding documentation appropriately?

@LiJie20190102
Copy link
Contributor Author

Could we separately add descriptions for checkpoint and savepoint, and update the corresponding documentation appropriately?

Okay, let me modify everything to checkpoint description. I copied it directly from Flink's description

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core SeaTunnel core module document

3 participants