-
Notifications
You must be signed in to change notification settings - Fork 2.1k
[Feature][seatunnel core][seatunnel-flink-start] Filnk engine supports task restore from checkpoint upon startup #10232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
…s task restore from checkpoint upon startup(apache#10220)
|
@yzeng1618 Please help review this PR, thx |
| + "kubernetes-session, yarn-application, kubernetes-application]") | ||
| private MasterType masterType; | ||
|
|
||
| /** restore checkpoint path */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The comment is inconsistent with the actual description of the savepoint parameter.
| @Parameter( | ||
| names = {"-s", "--fromSavepoint"}, | ||
| description = | ||
| "Path to a savepoint to restore the job from (for example, flink run -s hdfs:///flink/checkpoints/3c298a925d9a2a7837bbf5a8e4966b4f/chk-7902).") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The example describes a checkpoint, which is also inconsistent
|
Could we separately add descriptions for checkpoint and savepoint, and update the corresponding documentation appropriately? |
Okay, let me modify everything to checkpoint description. I copied it directly from Flink's description |
…rrock, an exception prompt 'Unknown HostException' appears
…rrock, an exception prompt 'Unknown HostException' appears
Purpose of this pull request
Filnk engine supports task restore from checkpoint upon startup, and issue is #10220
Does this PR introduce any user-facing change?
How was this patch tested?
Check list
New License Guide
incompatible-changes.mdto describe the incompatibility caused by this PR.