[Improve][Core] Auto-create GC log directory to avoid startup failures #10255
+66
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensure the Xloggc directory exists before starting the JVM to prevent GC logging failures when the configured directory doesn't exist. This change adds logic to automatically create the parent directory of the GC log file path specified by -Xloggc option. Changes: - Added GC logging options to jvm_options (commented by default) - Modified seatunnel.sh to auto-create GC log directory - Modified seatunnel-cluster.sh to auto-create GC log directory - Modified seatunnel.cmd to auto-create GC log directory - Modified seatunnel-cluster.cmd to auto-create GC log directory
Contributor
LiJie20190102
left a comment
LiJie20190102
left a comment
There was a problem hiding this comment.
LGTM， Please retry CI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this pull request
Support automatic creation of GC log directory
Changes
Does this PR introduce any user-facing change?
Yes. Users can now enable GC logging without manually creating the log directory first. The directory will be created automatically during startup.
How was this patch tested