Skip to content

Enable Behat coverage#85

Merged
dunglas merged 1 commit intoapi-platform:masterfrom
vincentchalamon:feature/behat-coverage
Jun 4, 2019
Merged

Enable Behat coverage#85
dunglas merged 1 commit intoapi-platform:masterfrom
vincentchalamon:feature/behat-coverage

Conversation

@vincentchalamon
Copy link
Contributor

@vincentchalamon vincentchalamon commented Jan 21, 2019 •
edited
Loading

Fix #84
@vincentchalamon vincentchalamon self-assigned this Jan 21, 2019
@vincentchalamon vincentchalamon removed the request for review from dunglas January 30, 2019 15:07
@vincentchalamon
Copy link
Contributor Author

vincentchalamon commented Jan 30, 2019

Could be replaced by leanphp/behat-code-coverage (once phpdg supported: leanphp/behat-code-coverage#42)
@dunglas
Copy link
Member

dunglas commented Jan 30, 2019

I prefer to keep our simple class than adding an extra dependency.
@vincentchalamon vincentchalamon requested a review from dunglas March 18, 2019 14:19
@pborreli pborreli force-pushed the master branch 2 times, most recently from 10cf5c2 to 8882512 Compare March 22, 2019 10:38
pborreli
pborreli reviewed Apr 6, 2019
View reviewed changes
@vincentchalamon vincentchalamon requested a review from pborreli April 8, 2019 06:46
@dunglas dunglas merged commit eadecf9 into api-platform:master Jun 4, 2019
@dunglas
Copy link
Member

dunglas commented Jun 4, 2019

Thanks @vincentchalamon
@vincentchalamon vincentchalamon deleted the feature/behat-coverage branch June 4, 2019 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

RFR

4 participants

@vincentchalamon @dunglas @pborreli @GregoireHebert